Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1292)

Unified Diff: third_party/WebKit/Source/web/AnimationWorkletProxyClientImpl.h

Issue 2774223002: CompositorWorkerProxyClientImpl to CompositorProxy cross thread reference is using WeakMember (Closed)
Patch Set: fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/AnimationWorkletProxyClientImpl.h
diff --git a/third_party/WebKit/Source/web/AnimationWorkletProxyClientImpl.h b/third_party/WebKit/Source/web/AnimationWorkletProxyClientImpl.h
index 22ff647cc97b17d75a3c7168e88ecb5bdac06179..1fc9c400b8d15113af1aa007a7230bce66c0ee0d 100644
--- a/third_party/WebKit/Source/web/AnimationWorkletProxyClientImpl.h
+++ b/third_party/WebKit/Source/web/AnimationWorkletProxyClientImpl.h
@@ -8,6 +8,7 @@
#include "core/dom/AnimationWorkletProxyClient.h"
#include "platform/heap/Handle.h"
#include "web/CompositorAnimator.h"
+#include "web/CompositorProxyClientImpl.h"
#include "wtf/Noncopyable.h"
namespace blink {
@@ -21,7 +22,8 @@ class CompositorMutatorImpl;
// This is constructed on the main thread but it is used in the worklet backing
// thread i.e., compositor thread.
class AnimationWorkletProxyClientImpl final
- : public AnimationWorkletProxyClient,
+ : public GarbageCollectedFinalized<AnimationWorkletProxyClientImpl>,
+ public AnimationWorkletProxyClient,
public CompositorAnimator {
WTF_MAKE_NONCOPYABLE(AnimationWorkletProxyClientImpl);
USING_GARBAGE_COLLECTED_MIXIN(AnimationWorkletProxyClientImpl);
@@ -35,13 +37,10 @@ class AnimationWorkletProxyClientImpl final
bool mutate(double monotonicTimeNow,
CompositorMutableStateProvider*) override;
- // CompositorProxyClient:
- void registerCompositorProxy(CompositorProxy*) override;
- void unregisterCompositorProxy(CompositorProxy*) override;
-
private:
CrossThreadPersistent<CompositorMutatorImpl> m_mutator;
- HeapHashSet<WeakMember<CompositorProxy>> m_proxies;
+
+ CrossThreadPersistent<CompositorProxyClientImpl> m_compositorProxyClient;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698