Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

Issue 2774223002: CompositorWorkerProxyClientImpl to CompositorProxy cross thread reference is using WeakMember (Closed)
Patch Set: fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
diff --git a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
index 6598af7b041e9cb5abafa1252a6996dcb52acc7a..cd34e2fdcdb8d85db96f06dcd27a6d039d9d0442 100644
--- a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
+++ b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
@@ -62,15 +62,18 @@ class TestCompositorWorkerObjectProxy : public InProcessWorkerObjectProxy {
: InProcessWorkerObjectProxy(nullptr, parentFrameTaskRunners) {}
};
-class TestCompositorWorkerProxyClient : public CompositorWorkerProxyClient {
+class TestCompositorWorkerProxyClient
+ : public GarbageCollected<TestCompositorWorkerProxyClient>,
+ public CompositorWorkerProxyClient {
+ USING_GARBAGE_COLLECTED_MIXIN(TestCompositorWorkerProxyClient);
+
public:
TestCompositorWorkerProxyClient() {}
void dispose() override {}
void setGlobalScope(WorkerGlobalScope*) override {}
void requestAnimationFrame() override {}
- void registerCompositorProxy(CompositorProxy*) override {}
- void unregisterCompositorProxy(CompositorProxy*) override {}
+ CompositorProxyClient* compositorProxyClient() override { return nullptr; };
};
class CompositorWorkerTestPlatform : public TestingPlatformSupport {

Powered by Google App Engine
This is Rietveld 408576698