Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2774183002: Add a few missing files (including a test) to base/BUILD.gn (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a few missing files (including a test) to base/BUILD.gn BUG=661774 Review-Url: https://codereview.chromium.org/2774183002 Cr-Commit-Position: refs/heads/master@{#459670} Committed: https://chromium.googlesource.com/chromium/src/+/8318c659370c46679a96d84b5735a708110c53fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M base/BUILD.gn View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Nico
3 years, 9 months ago (2017-03-26 02:00:25 UTC) #4
Mark Mentovai
LGTM
3 years, 9 months ago (2017-03-26 02:16:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774183002/1
3 years, 9 months ago (2017-03-26 03:03:33 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-26 03:45:58 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8318c659370c46679a96d84b5735...

Powered by Google App Engine
This is Rietveld 408576698