Make screen.orientation implementation use WebScreenInfo::orientationType

Source/core/frame/LocalFrame.cpp

Index: Source/core/frame/LocalFrame.cpp
diff --git a/Source/core/frame/LocalFrame.cpp b/Source/core/frame/LocalFrame.cpp
index 1fd588bc1e4d5888ecc1767e69ce62b1327a3a99..7ef28dcec48d3969cd876e9678f3e3ec04a58c1b 100644
--- a/Source/core/frame/LocalFrame.cpp
+++ b/Source/core/frame/LocalFrame.cpp
@@ -164,7 +164,7 @@ void LocalFrame::setView(PassRefPtr<FrameView> view)
 
 void LocalFrame::sendOrientationChangeEvent()
 {
-    if (!RuntimeEnabledFeatures::orientationEventEnabled())
+    if (!RuntimeEnabledFeatures::orientationEventEnabled() && !RuntimeEnabledFeatures::screenOrientationEnabled())

[mlamouri (slow - plz ping), 2014/05/19 14:06:15]

window.orientation has a bug wrt to orientationchange event that wasn't applying
to screen orientation because of the different implementation. render_view_impl
notifies the main frame about the change of orientation but the main frame
doesn't notify its sub-frames so if you have a frame listening to orientation
changes, it will never be notified.

Maybe we could move the API at the WebView level so the Page could notifies all
the frames? Alternatively, the LocalFrame could notifies its children that would
then notify theirs. I don't know which way would be following Blink common
patterns. I would prefer using Page as a dispatcher FWIW.

[Inactive, 2014/05/19 15:14:30]

Ok, I'll take a look. I think we can traverse subframes here and fire the events
on their window as well.

[Inactive, 2014/05/19 16:05:26]

Done and added a layout test to cover this.

         return;
 
     if (DOMWindow* window = domWindow())