Make screen.orientation implementation use WebScreenInfo::orientationType

Source/core/frame/LocalFrame.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Simon Hausmann <hausmann@kde.org>
  *                     2000 Stefan Schimanski <1Stein@gmx.de>
  *                     2001 George Staikos <staikos@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
@@ skipping 146 matching lines @@
     if (m_view && isMainFrame()) {
         if (settings()->pinchVirtualViewportEnabled())
             m_host->pinchViewport().mainFrameDidChangeSize();
         else
             m_view->setVisibleContentScaleFactor(page()->pageScaleFactor());
     }
 }
 
 void LocalFrame::sendOrientationChangeEvent()
 {
-    if (!RuntimeEnabledFeatures::orientationEventEnabled())
+    if (!RuntimeEnabledFeatures::orientationEventEnabled() && !RuntimeEnabledFeatures::screenOrientationEnabled())

[mlamouri (slow - plz ping), 2014/05/19 14:06:15]

window.orientation has a bug wrt to orientationchange event that wasn't applying
to screen orientation because of the different implementation. render_view_impl
notifies the main frame about the change of orientation but the main frame
doesn't notify its sub-frames so if you have a frame listening to orientation
changes, it will never be notified.

Maybe we could move the API at the WebView level so the Page could notifies all
the frames? Alternatively, the LocalFrame could notifies its children that would
then notify theirs. I don't know which way would be following Blink common
patterns. I would prefer using Page as a dispatcher FWIW.

[Inactive, 2014/05/19 15:14:30]

Ok, I'll take a look. I think we can traverse subframes here and fire the events
on their window as well.

[Inactive, 2014/05/19 16:05:26]

Done and added a layout test to cover this.

         return;
 
     if (DOMWindow* window = domWindow())
         window->dispatchEvent(Event::create(EventTypeNames::orientationchange));
 }
 
 void LocalFrame::setPrinting(bool printing, const FloatSize& pageSize, const FloatSize& originalPageSize, float maximumShrinkRatio)
 {
     // In setting printing, we should not validate resources already cached for the document.
     // See https://bugs.webkit.org/show_bug.cgi?id=43704
@@ skipping 463 matching lines @@
 LocalFrame* LocalFrame::localFrameRoot()
 {
     LocalFrame* curFrame = this;
     while (curFrame && curFrame->tree().parent() && curFrame->tree().parent()->isLocalFrame())
         curFrame = curFrame->tree().parent();
 
     return curFrame;
 }
 
 } // namespace WebCore