MD Settings: Don't search inside <dialog> elements.

MD Settings: Don't search inside <dialog> elements.

The disconnectDialog inside people-page was being searched erroneously
causing the people section to be returned as a result, instead of displaying 
the "no results found" message.

BUG=704880
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2774003002
Cr-Commit-Position: refs/heads/master@{#459549}
Committed: https://chromium.googlesource.com/chromium/src/+/2ad0e26fba82875b90424b386851cfd1abd855a0

[dpapad, 2017-03-24 18:26:15]

Description was changed from

==========
MD Settings: Don't search inside <dialog> elements.

BUG=704880
==========

to

==========
MD Settings: Don't search inside <dialog> elements.

BUG=704880
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-03-24 18:28:13]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 18:29:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-03-24 18:31:00]

Description was changed from

==========
MD Settings: Don't search inside <dialog> elements.

BUG=704880
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Don't search inside <dialog> elements.

The disconnectDialog inside people-page was being searched erroneously
causing the people section to be returned as a result, instead of displaying 
the "no results found" message.

BUG=704880
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-03-24 18:31:09]

dpapad@chromium.org changed reviewers:
+ tommycli@chromium.org

[tommycli, 2017-03-24 19:07:19]

lgtm except:

https://codereview.chromium.org/2774003002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/search_settings.js (left):

https://codereview.chromium.org/2774003002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_settings.js:55: 'PAPER-ITEM',
I assume you've determined this is no longer needed? Were you supposed to add a
replacement element?

[dpapad, 2017-03-24 19:13:22]

https://codereview.chromium.org/2774003002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/search_settings.js (left):

https://codereview.chromium.org/2774003002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_settings.js:55: 'PAPER-ITEM',
On 2017/03/24 at 19:07:19, tommycli wrote:
> I assume you've determined this is no longer needed? Were you supposed to add
a replacement element?

Yes no longer needed, because we removed all paper-item instances from our code.
There is no replacement either, because paper-item existed inside iron-dropdown
elements to implement action menus. Since then action menus are implemented as
<dialog>s too, and are correctly ignored by (as a result of this change).

[commit-bot: I haz the power, 2017-03-24 20:07:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 20:07:34]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-03-24 20:42:01]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-03-24 20:43:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 21:00:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490388121097240, "parent_rev":
"68e83a343963981524faa8e03fc6cc274ecc8409", "commit_rev":
"2ad0e26fba82875b90424b386851cfd1abd855a0"}

[commit-bot: I haz the power, 2017-03-24 21:01:14]

Description was changed from

==========
MD Settings: Don't search inside <dialog> elements.

The disconnectDialog inside people-page was being searched erroneously
causing the people section to be returned as a result, instead of displaying 
the "no results found" message.

BUG=704880
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Don't search inside <dialog> elements.

The disconnectDialog inside people-page was being searched erroneously
causing the people section to be returned as a result, instead of displaying 
the "no results found" message.

BUG=704880
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2774003002
Cr-Commit-Position: refs/heads/master@{#459549}
Committed:
https://chromium.googlesource.com/chromium/src/+/2ad0e26fba82875b90424b386851...
==========

[commit-bot: I haz the power, 2017-03-24 21:01:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2ad0e26fba82875b90424b386851...

[Dan Beam, 2017-03-27 11:10:35]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-03-27 11:10:35]

does this affect cbd?

why not just add no-search on more dialogs?

[dpapad, 2017-03-27 17:34:21]

On 2017/03/27 at 11:10:35, dbeam wrote:
> does this affect cbd?
No it does not. The CBD dialog does not exist in the DOM (it is behind a dom-if,
with "restamp" too), so it was never searched, even before this CL. This is by
design, since we had decided to not search dialogs to begin with.

> 
> why not just add no-search on more dialogs?
We could do this, but as said above, there isn't any dialog we want to search,
so it makes more sense to add 'DIALOG' to the ignored elements set instead of
adding multiple 'no-search' attributes.