Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2773923002: Remove unused LayoutView::selectionStatrt/End functions (Closed)

Created:
3 years, 9 months ago by yoichio
Modified:
3 years, 9 months ago
Reviewers:
yosin_UTC9, kojii
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused LayoutView::selectionStatrt/End functions TEST=No change in behavior Review-Url: https://codereview.chromium.org/2773923002 Cr-Commit-Position: refs/heads/master@{#459711} Committed: https://chromium.googlesource.com/chromium/src/+/43d60fabe17ef7d4c63680b49d30b9072b31bb67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutView.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
yoichio
3 years, 9 months ago (2017-03-24 05:55:13 UTC) #5
yosin_UTC9
lgtm Good catch!
3 years, 9 months ago (2017-03-24 06:15:40 UTC) #6
kojii
lgtm. Wow.
3 years, 9 months ago (2017-03-24 06:26:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773923002/1
3 years, 9 months ago (2017-03-27 02:16:20 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/348359)
3 years, 9 months ago (2017-03-27 03:56:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773923002/1
3 years, 9 months ago (2017-03-27 06:39:48 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 07:04:25 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/43d60fabe17ef7d4c63680b49d30...

Powered by Google App Engine
This is Rietveld 408576698