Rename AutofillClientPositionWhenInsideOOPIF and move it to interactive tests

Rename AutofillClientPositionWhenInsideOOPIF and move it to interactive tests

The test is currently flaking on different platforms. The failure is due
to incorrect boudns reported either through focused node change event,
or AutofillClient. The failure is hard to reporoduce locally and the
logs do not provde proper visibility as to what the root cause could be.

This CL will:
  1- Move the test from browser_tests to interactive_ui_tests.
  2- Renames the test move appropriately to address vabr@'s comment in the
  original CL https://codereview.chromium.org/2754033002 (we are testing
  a popup position and the term "AutofillClient" is incorrect).
  3- Adds a log when the test fails to show the focused node bouds as
  well as those reported by autofill client and give us a hint on which
  one might be incorrect.

BUG=704943, 686129
Review-Url: https://codereview.chromium.org/2773823003
Cr-Commit-Position: refs/heads/master@{#459535}
Committed: https://chromium.googlesource.com/chromium/src/+/9febb1f84922d7307712a044550c9ad0640b64d3

[EhsanK, 2017-03-24 16:07:38]

ekaramad@chromium.org changed reviewers:
+ alexmos@chromium.org

[EhsanK, 2017-03-24 16:07:39]

Hello Alex. As I explained in the CL the test is flaky. I uses simulate keyboard
event which might be the cause but since I have not been able to repro locally I
cannot confirm.

PTAL.

[alexmos, 2017-03-24 18:10:22]

LGTM, hope this unflakes it.

https://codereview.chromium.org/2773823003/diff/1/chrome/browser/site_per_pro...
File chrome/browser/site_per_process_interactive_browsertest.cc (right):

https://codereview.chromium.org/2773823003/diff/1/chrome/browser/site_per_pro...
chrome/browser/site_per_process_interactive_browsertest.cc:1028: // The
notification contains
nit: unfinished sentence.  It was that way before, but might be a good
opportunity to fix it/remove it while you're here.

[EhsanK, 2017-03-24 19:37:16]

Thanks Alex for the review! I will try to land it now.

https://codereview.chromium.org/2773823003/diff/1/chrome/browser/site_per_pro...
File chrome/browser/site_per_process_interactive_browsertest.cc (right):

https://codereview.chromium.org/2773823003/diff/1/chrome/browser/site_per_pro...
chrome/browser/site_per_process_interactive_browsertest.cc:1028: // The
notification contains
On 2017/03/24 18:10:21, alexmos wrote:
> nit: unfinished sentence.  It was that way before, but might be a good
> opportunity to fix it/remove it while you're here.

Thanks for catching this. Done.

[EhsanK, 2017-03-24 19:37:25]

The CQ bit was checked by ekaramad@chromium.org

[EhsanK, 2017-03-24 19:37:26]

The patchset sent to the CQ was uploaded after l-g-t-m from alexmos@chromium.org
Link to the patchset: https://codereview.chromium.org/2773823003/#ps20001
(title: "Fixed a typo")

[commit-bot: I haz the power, 2017-03-24 19:38:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 20:26:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490384245839300,
"parent_rev": "ce2c6a0975b9692f994293af616f2410fcd8475e", "commit_rev":
"9febb1f84922d7307712a044550c9ad0640b64d3"}

[commit-bot: I haz the power, 2017-03-24 20:26:52]

Description was changed from

==========
Rename AutofillClientPositionWhenInsideOOPIF and move it to interactive tests

The test is currently flaking on different platforms. The failure is due
to incorrect boudns reported either through focused node change event,
or AutofillClient. The failure is hard to reporoduce locally and the
logs do not provde proper visibility as to what the root cause could be.

This CL will:
  1- Move the test from browser_tests to interactive_ui_tests.
  2- Renames the test move appropriately to address vabr@'s comment in the
  original CL https://codereview.chromium.org/2754033002 (we are testing
  a popup position and the term "AutofillClient" is incorrect).
  3- Adds a log when the test fails to show the focused node bouds as
  well as those reported by autofill client and give us a hint on which
  one might be incorrect.

BUG=704943,686129
==========

to

==========
Rename AutofillClientPositionWhenInsideOOPIF and move it to interactive tests

The test is currently flaking on different platforms. The failure is due
to incorrect boudns reported either through focused node change event,
or AutofillClient. The failure is hard to reporoduce locally and the
logs do not provde proper visibility as to what the root cause could be.

This CL will:
  1- Move the test from browser_tests to interactive_ui_tests.
  2- Renames the test move appropriately to address vabr@'s comment in the
  original CL https://codereview.chromium.org/2754033002 (we are testing
  a popup position and the term "AutofillClient" is incorrect).
  3- Adds a log when the test fails to show the focused node bouds as
  well as those reported by autofill client and give us a hint on which
  one might be incorrect.

BUG=704943,686129

Review-Url: https://codereview.chromium.org/2773823003
Cr-Commit-Position: refs/heads/master@{#459535}
Committed:
https://chromium.googlesource.com/chromium/src/+/9febb1f84922d7307712a044550c...
==========

[commit-bot: I haz the power, 2017-03-24 20:26:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9febb1f84922d7307712a044550c...