Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: tools/perf/core/perf_data_generator.py

Issue 2773743002: Updating the script to include sizes and resource sizes benchmarks (Closed)
Patch Set: Updating the script to include sizes and resource sizes benchmarks Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/perf/benchmark.csv ('K') | « tools/perf/benchmark.csv ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/core/perf_data_generator.py
diff --git a/tools/perf/core/perf_data_generator.py b/tools/perf/core/perf_data_generator.py
index 7aac36a6b79d00dacf8e1d45d34606dc93282630..b1505c4c08572cfda345cf8712f353e9a8cd3c30 100755
--- a/tools/perf/core/perf_data_generator.py
+++ b/tools/perf/core/perf_data_generator.py
@@ -806,7 +806,8 @@ def tests_are_up_to_date(waterfalls):
config_data = fp.read().strip()
all_tests.update(tests)
up_to_date &= tests_data == config_data
- verify_all_tests_in_benchmark_csv(all_tests, get_all_benchmarks_metadata())
+ verify_all_tests_in_benchmark_csv(all_tests,
+ get_all_waterfall_benchmarks_metadata())
return up_to_date
@@ -819,7 +820,8 @@ def update_all_tests(waterfalls):
json.dump(tests, fp, indent=2, separators=(',', ': '), sort_keys=True)
fp.write('\n')
all_tests.update(tests)
- verify_all_tests_in_benchmark_csv(all_tests, get_all_benchmarks_metadata())
+ verify_all_tests_in_benchmark_csv(all_tests,
+ get_all_waterfall_benchmarks_metadata())
def src_dir():
@@ -843,9 +845,22 @@ NON_TELEMETRY_BENCHMARKS = {
}
-# Returns a dictionary mapping benchmark name to benchmark owner metadata
-def get_all_benchmarks_metadata():
- metadata = NON_TELEMETRY_BENCHMARKS
+# If you change this dictionary, run tools/perf/generate_perf_data
+NON_WATERFALL_BENCHMARKS = {
+ 'sizes (mac)': BenchmarkMetadata('tapted', None),
nednguyen 2017/03/23 17:15:28 all these owner should be @chromium.org? Maybe we
+ 'sizes (win)': BenchmarkMetadata('grt', None),
+ 'sizes (linux)': BenchmarkMetadata('thestig', None),
+ 'resource_sizes': BenchmarkMetadata('agrieve, rnephew, perezju', None)
+}
+
+
+# Returns a dictionary mapping waterfall benchmark name to benchmark owner
+# metadata
+def get_all_waterfall_benchmarks_metadata():
+ return get_all_benchmarks_metadata(NON_TELEMETRY_BENCHMARKS)
+
+
+def get_all_benchmarks_metadata(metadata):
benchmark_list = current_benchmarks(False)
for benchmark in benchmark_list:
@@ -897,7 +912,9 @@ def update_benchmark_csv():
]
csv_data = []
- benchmark_metadata = get_all_benchmarks_metadata()
+ all_benchmarks = NON_TELEMETRY_BENCHMARKS
+ all_benchmarks.update(NON_WATERFALL_BENCHMARKS)
+ benchmark_metadata = get_all_benchmarks_metadata(all_benchmarks)
for benchmark_name in benchmark_metadata:
csv_data.append([
benchmark_name,
« tools/perf/benchmark.csv ('K') | « tools/perf/benchmark.csv ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698