Updating the script to include sizes and resource sizes benchmarks

tools/perf/core/perf_data_generator.py

 #!/usr/bin/env python
 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Script to generate chromium.perf.json and chromium.perf.fyi.json in
 the src/testing/buildbot directory and benchmark.csv in the src/tools/perf
 directory. Maintaining these files by hand is too unwieldy.
 """
 import argparse
@@ skipping 788 matching lines @@
   all_tests = {}
   for w in waterfalls:
     tests = generate_all_tests(w)
     tests_data = json.dumps(tests, indent=2, separators=(',', ': '),
                             sort_keys=True)
     config_file = get_json_config_file_for_waterfall(w)
     with open(config_file, 'r') as fp:
       config_data = fp.read().strip()
     all_tests.update(tests)
     up_to_date &= tests_data == config_data
-  verify_all_tests_in_benchmark_csv(all_tests, get_all_benchmarks_metadata())
+  verify_all_tests_in_benchmark_csv(all_tests,
+                                    get_all_waterfall_benchmarks_metadata())
   return up_to_date
 
 
 def update_all_tests(waterfalls):
   all_tests = {}
   for w in waterfalls:
     tests = generate_all_tests(w)
     config_file = get_json_config_file_for_waterfall(w)
     with open(config_file, 'w') as fp:
       json.dump(tests, fp, indent=2, separators=(',', ': '), sort_keys=True)
       fp.write('\n')
     all_tests.update(tests)
-  verify_all_tests_in_benchmark_csv(all_tests, get_all_benchmarks_metadata())
+  verify_all_tests_in_benchmark_csv(all_tests,
+                                    get_all_waterfall_benchmarks_metadata())
 
 
 def src_dir():
   file_path = os.path.abspath(__file__)
   return os.path.dirname(os.path.dirname(
       os.path.dirname(os.path.dirname(file_path))))
 
 
 BenchmarkMetadata = collections.namedtuple(
     'BenchmarkMetadata', 'emails component')
 NON_TELEMETRY_BENCHMARKS = {
     'angle_perftests': BenchmarkMetadata('jmadill@chromium.org', None),
     'cc_perftests': BenchmarkMetadata('enne@chromium.org', None),
     'gpu_perftests': BenchmarkMetadata('reveman@chromium.org', None),
     'tracing_perftests': BenchmarkMetadata(
         'kkraynov@chromium.org, primiano@chromium.org', None),
     'load_library_perf_tests': BenchmarkMetadata(None, None),
     'media_perftests': BenchmarkMetadata('crouleau@chromium.org', None),
     'performance_browser_tests': BenchmarkMetadata(
         'hubbe@chromium.org, justinlin@chromium.org, miu@chromium.org', None)
 }
 
 
-# Returns a dictionary mapping benchmark name to benchmark owner metadata
-def get_all_benchmarks_metadata():
-  metadata = NON_TELEMETRY_BENCHMARKS
+# If you change this dictionary, run tools/perf/generate_perf_data
+NON_WATERFALL_BENCHMARKS = {
+    'sizes (mac)': BenchmarkMetadata('tapted', None),

[nednguyen, 2017/03/23 17:15:28]

all these owner should be @chromium.org?

Maybe we should add some assertion about owner's email.

+    'sizes (win)': BenchmarkMetadata('grt', None),
+    'sizes (linux)': BenchmarkMetadata('thestig', None),
+    'resource_sizes': BenchmarkMetadata('agrieve, rnephew, perezju', None)
+}
+
+
+# Returns a dictionary mapping waterfall benchmark name to benchmark owner
+# metadata
+def get_all_waterfall_benchmarks_metadata():
+  return get_all_benchmarks_metadata(NON_TELEMETRY_BENCHMARKS)
+
+
+def get_all_benchmarks_metadata(metadata):
   benchmark_list = current_benchmarks(False)
 
   for benchmark in benchmark_list:
     emails = decorators.GetEmails(benchmark)
     if emails:
       emails = ', '.join(emails)
     metadata[benchmark.Name()] = BenchmarkMetadata(
         emails, decorators.GetComponent(benchmark))
   return metadata
 
@@ skipping 31 matching lines @@
 
   Updates telemetry/perf/benchmark.csv containing the current benchmark names,
   owners, and components.
   """
   header_data = [['AUTOGENERATED FILE DO NOT EDIT'],
       ['See //tools/perf/generate_perf_data.py to make changes'],
       ['Benchmark name', 'Individual owners', 'Component']
   ]
 
   csv_data = []
-  benchmark_metadata = get_all_benchmarks_metadata()
+  all_benchmarks = NON_TELEMETRY_BENCHMARKS
+  all_benchmarks.update(NON_WATERFALL_BENCHMARKS)
+  benchmark_metadata = get_all_benchmarks_metadata(all_benchmarks)
   for benchmark_name in benchmark_metadata:
     csv_data.append([
         benchmark_name,
         benchmark_metadata[benchmark_name].emails,
         benchmark_metadata[benchmark_name].component
     ])
 
   csv_data = sorted(csv_data, key=lambda b: b[0])
   csv_data = header_data + csv_data
 
@@ skipping 27 matching lines @@
       return 0
     else:
       print ('The perf JSON config files are not up-to-date. Please run %s '
              'without --validate-only flag to update the perf JSON '
              'configs and benchmark.csv.') % sys.argv[0]
       return 1
   else:
     update_all_tests([fyi_waterfall, waterfall])
     update_benchmark_csv()
   return 0