Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2773743002: Updating the script to include sizes and resource sizes benchmarks (Closed)

Created:
3 years, 9 months ago by ashleymarie1
Modified:
3 years, 9 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating the script to include sizes and resource sizes benchmarks BUG=chromium:575318 Submitted via gerrit without problems here: https://chromium-review.googlesource.com/c/459438/

Patch Set 1 #

Patch Set 2 : Updating the script to include sizes and resource sizes benchmarks #

Patch Set 3 : Updating the script to include sizes and resource sizes benchmarks #

Total comments: 3

Patch Set 4 : Updating the script to include sizes and resource sizes benchmarks #

Patch Set 5 : Handling merge from git pull #

Patch Set 6 : Updating the script to include sizes and resource sizes benchmarks #

Patch Set 7 : retrying upload after more git magic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M tools/perf/benchmark.csv View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/core/perf_data_generator.py View 1 2 3 4 4 chunks +25 lines, -6 lines 0 comments Download

Messages

Total messages: 31 (15 generated)
ashleymarie1
3 years, 9 months ago (2017-03-23 17:05:00 UTC) #2
nednguyen
https://codereview.chromium.org/2773743002/diff/40001/tools/perf/core/perf_data_generator.py File tools/perf/core/perf_data_generator.py (right): https://codereview.chromium.org/2773743002/diff/40001/tools/perf/core/perf_data_generator.py#newcode850 tools/perf/core/perf_data_generator.py:850: 'sizes (mac)': BenchmarkMetadata('tapted', None), all these owner should be ...
3 years, 9 months ago (2017-03-23 17:15:28 UTC) #3
nednguyen
https://codereview.chromium.org/2773743002/diff/40001/tools/perf/benchmark.csv File tools/perf/benchmark.csv (left): https://codereview.chromium.org/2773743002/diff/40001/tools/perf/benchmark.csv#oldcode162 tools/perf/benchmark.csv:162: tab_switching.five_blank_pages,, what happens to these?
3 years, 9 months ago (2017-03-23 17:41:33 UTC) #4
ashleymarie1
On 2017/03/23 17:15:28, nednguyen wrote: > https://codereview.chromium.org/2773743002/diff/40001/tools/perf/core/perf_data_generator.py > File tools/perf/core/perf_data_generator.py (right): > > https://codereview.chromium.org/2773743002/diff/40001/tools/perf/core/perf_data_generator.py#newcode850 > ...
3 years, 9 months ago (2017-03-23 22:00:40 UTC) #5
ashleymarie1
https://codereview.chromium.org/2773743002/diff/40001/tools/perf/benchmark.csv File tools/perf/benchmark.csv (left): https://codereview.chromium.org/2773743002/diff/40001/tools/perf/benchmark.csv#oldcode162 tools/perf/benchmark.csv:162: tab_switching.five_blank_pages,, On 2017/03/23 17:41:33, nednguyen wrote: > what happens ...
3 years, 9 months ago (2017-03-23 22:00:47 UTC) #6
nednguyen
lgtm
3 years, 9 months ago (2017-03-23 22:02:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773743002/60001
3 years, 9 months ago (2017-03-23 22:21:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/176502) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-23 22:25:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773743002/80001
3 years, 9 months ago (2017-03-23 22:38:05 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/176519) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-23 22:41:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773743002/80001
3 years, 9 months ago (2017-03-24 13:26:37 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/176910) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-24 13:28:43 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773743002/100001
3 years, 9 months ago (2017-03-24 13:42:39 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/62219) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-24 13:44:37 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773743002/120001
3 years, 9 months ago (2017-03-24 13:52:26 UTC) #28
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 13:54:48 UTC) #30
Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

Powered by Google App Engine
This is Rietveld 408576698