|
|
Chromium Code Reviews|
Created:
3 years, 9 months ago by ashleymarie1 Modified:
3 years, 9 months ago Reviewers:
nednguyen CC:
chromium-reviews, telemetry-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdating the script to include sizes and resource sizes benchmarks
BUG=chromium:575318
Submitted via gerrit without problems here: https://chromium-review.googlesource.com/c/459438/
Patch Set 1 #Patch Set 2 : Updating the script to include sizes and resource sizes benchmarks #Patch Set 3 : Updating the script to include sizes and resource sizes benchmarks #
Total comments: 3
Patch Set 4 : Updating the script to include sizes and resource sizes benchmarks #Patch Set 5 : Handling merge from git pull #Patch Set 6 : Updating the script to include sizes and resource sizes benchmarks #Patch Set 7 : retrying upload after more git magic #Messages
Total messages: 31 (15 generated)
ashleymarie@chromium.org changed reviewers: + nednguyen@google.com
https://codereview.chromium.org/2773743002/diff/40001/tools/perf/core/perf_da... File tools/perf/core/perf_data_generator.py (right): https://codereview.chromium.org/2773743002/diff/40001/tools/perf/core/perf_da... tools/perf/core/perf_data_generator.py:850: 'sizes (mac)': BenchmarkMetadata('tapted', None), all these owner should be @chromium.org? Maybe we should add some assertion about owner's email.
https://codereview.chromium.org/2773743002/diff/40001/tools/perf/benchmark.csv File tools/perf/benchmark.csv (left): https://codereview.chromium.org/2773743002/diff/40001/tools/perf/benchmark.cs... tools/perf/benchmark.csv:162: tab_switching.five_blank_pages,, what happens to these?
On 2017/03/23 17:15:28, nednguyen wrote: > https://codereview.chromium.org/2773743002/diff/40001/tools/perf/core/perf_da... > File tools/perf/core/perf_data_generator.py (right): > > https://codereview.chromium.org/2773743002/diff/40001/tools/perf/core/perf_da... > tools/perf/core/perf_data_generator.py:850: 'sizes (mac)': > BenchmarkMetadata('tapted', None), > all these owner should be @chromium.org? > > Maybe we should add some assertion about owner's email. Whoops, fixed it I'm thinking we should add that assertion when we require that an email address exist for each benchmark; that way we can check everything in the same place
https://codereview.chromium.org/2773743002/diff/40001/tools/perf/benchmark.csv File tools/perf/benchmark.csv (left): https://codereview.chromium.org/2773743002/diff/40001/tools/perf/benchmark.cs... tools/perf/benchmark.csv:162: tab_switching.five_blank_pages,, On 2017/03/23 17:41:33, nednguyen wrote: > what happens to these? I believe it was out of sync when I was submitting the initial change
lgtm
The CQ bit was checked by ashleymarie@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by ashleymarie@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2773743002/#ps80001 (title: "Handling merge from git pull")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ashleymarie@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by ashleymarie@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2773743002/#ps100001 (title: "Updating the script to include sizes and resource sizes benchmarks")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by ashleymarie@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2773743002/#ps120001 (title: "retrying upload after more git magic")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
Description was changed from ========== Updating the script to include sizes and resource sizes benchmarks BUG=chromium:575318 ========== to ========== Updating the script to include sizes and resource sizes benchmarks BUG=chromium:575318 Submitted via gerrit without problems here: https://chromium-review.googlesource.com/c/459438/ ========== |
