Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1422)

Issue 2773723002: [inspector] fixed compilation with gyp (Closed)

Created:
3 years, 9 months ago by kozy
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] fixed compilation with gyp BUG=none TBR=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2773723002 Cr-Commit-Position: refs/heads/master@{#44064} Committed: https://chromium.googlesource.com/v8/v8/+/03179ab375ff3e1a9869d252a1a86f19563830ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M src/inspector/v8-debugger-agent-impl.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M test/inspector/task-runner.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773723002/1
3 years, 9 months ago (2017-03-23 14:46:09 UTC) #2
Michael Achenbach
lgtm
3 years, 9 months ago (2017-03-23 15:01:05 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 15:39:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/03179ab375ff3e1a9869d252a1a86f19563...

Powered by Google App Engine
This is Rietveld 408576698