|
|
Chromium Code Reviews|
Created:
3 years, 9 months ago by Dan Beam Modified:
3 years, 9 months ago CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: push pixels to the screen faster
This CL simulates the future layout of the settings page
in simple HTML/CSS before the components load.
BUG=597347
R=dpapad@chromium.org
TBR=esprehn@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2773613002
Cr-Commit-Position: refs/heads/master@{#459192}
Committed: https://chromium.googlesource.com/chromium/src/+/e310625929d561ce55c6ffc107c5a708912534e3
Patch Set 1 : looks good to me... #
Messages
Total messages: 21 (15 generated)
Description was changed from ========== WIP: show dpapad@ my proposed app shell for settings BUG= ========== to ========== WIP: show dpapad@ my proposed app shell for settings BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== WIP: show dpapad@ my proposed app shell for settings BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: push pixels to the screen faster Let's show some things that we highly suspect will be eventually true by simulating our layout earlier in the HTML. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== MD Settings: push pixels to the screen faster Let's show some things that we highly suspect will be eventually true by simulating our layout earlier in the HTML. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: push pixels to the screen faster Let's show some things that we highly suspect will be eventually true by simulating our layout earlier in the HTML. BUG= R=esprehn@chromium.org,dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dbeam@chromium.org changed reviewers: + dpapad@chromium.org, esprehn@chromium.org
Description was changed from ========== MD Settings: push pixels to the screen faster Let's show some things that we highly suspect will be eventually true by simulating our layout earlier in the HTML. BUG= R=esprehn@chromium.org,dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: push pixels to the screen faster Let's show some things that we highly suspect will be eventually true by simulating our layout earlier in the HTML. BUG=597347 R=esprehn@chromium.org,dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM++
Description was changed from ========== MD Settings: push pixels to the screen faster Let's show some things that we highly suspect will be eventually true by simulating our layout earlier in the HTML. BUG=597347 R=esprehn@chromium.org,dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: push pixels to the screen faster This CL simulates the future layout of the settings page in simple HTML/CSS before the components load. BUG=597347 R=esprehn@chromium.org,dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== MD Settings: push pixels to the screen faster This CL simulates the future layout of the settings page in simple HTML/CSS before the components load. BUG=597347 R=esprehn@chromium.org,dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: push pixels to the screen faster This CL simulates the future layout of the settings page in simple HTML/CSS before the components load. BUG=597347 R=dpapad@chromium.org TBR=esprehn@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
esprehn@: gonna cq this so it starts showing up for others on canary. let me know if you have suggestions to improve. note: in the vulcanized version the md_colors <link> becomes an inline <style> so probably less to block the <body> from painting.
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490299264512920,
"parent_rev": "a75871227d372a8b0ddd0638a075b56eff4f7380", "commit_rev":
"e310625929d561ce55c6ffc107c5a708912534e3"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: push pixels to the screen faster This CL simulates the future layout of the settings page in simple HTML/CSS before the components load. BUG=597347 R=dpapad@chromium.org TBR=esprehn@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: push pixels to the screen faster This CL simulates the future layout of the settings page in simple HTML/CSS before the components load. BUG=597347 R=dpapad@chromium.org TBR=esprehn@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2773613002 Cr-Commit-Position: refs/heads/master@{#459192} Committed: https://chromium.googlesource.com/chromium/src/+/e310625929d561ce55c6ffc107c5... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/e310625929d561ce55c6ffc107c5...
Message was sent while issue was closed.
lgtm, it'd be even faster to just inline those variables though. :) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
