Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2773613002: MD Settings: push pixels to the screen faster (Closed)

Created:
3 years, 9 months ago by Dan Beam
Modified:
3 years, 9 months ago
Reviewers:
esprehn, dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: push pixels to the screen faster This CL simulates the future layout of the settings page in simple HTML/CSS before the components load. BUG=597347 R=dpapad@chromium.org TBR=esprehn@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2773613002 Cr-Commit-Position: refs/heads/master@{#459192} Committed: https://chromium.googlesource.com/chromium/src/+/e310625929d561ce55c6ffc107c5a708912534e3

Patch Set 1 : looks good to me... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M chrome/browser/resources/settings/settings.html View 1 chunk +15 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Dan Beam
3 years, 9 months ago (2017-03-23 11:49:23 UTC) #7
dpapad
LGTM++
3 years, 9 months ago (2017-03-23 16:58:02 UTC) #12
Dan Beam
esprehn@: gonna cq this so it starts showing up for others on canary. let me ...
3 years, 9 months ago (2017-03-23 20:00:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773613002/20001
3 years, 9 months ago (2017-03-23 20:01:55 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/e310625929d561ce55c6ffc107c5a708912534e3
3 years, 9 months ago (2017-03-23 20:10:01 UTC) #20
esprehn
3 years, 9 months ago (2017-03-23 20:12:12 UTC) #21
Message was sent while issue was closed.
lgtm, it'd be even faster to just inline those variables though. :)

Powered by Google App Engine
This is Rietveld 408576698