Image Capture: prune Photo{Capabilities/Settings} and add MediaTrackConstraintSet.pointsOfInterest

Image Capture: prune Photo{Capabilities/Settings} and add MediaTrackConstraintSet.pointsOfInterest

- This CL removes from PhotoCapabilities.idl the fields that are
not there anymore according to the spec [1], leaving just four 
of them.  The corresponding code and LayoutTests are updated.
Same for PhotoSettings.idl [2].

- This CL also adds ConstrainPoint2D data type [3] and uses it
for MediaTrackConstraintSet.pointsOfInterest, wiring it down 
to the mojo interface and in the mock.

- This is the one and only important change visible to the users. 
(There is an Origin Trial going on for Image Capture in 
M56-57-58, but these changes will land in 59.x.y.z, so shouldn't 
affect them, in any case an update to blink-dev@ is being 
brewed and there's a migration guide:
  https://tinyurl.com/image-capture-migration-guide
)

- No more MediaStreamTrack idl changes are expected after
this CL \o/


TEST= Layouttests etc updated.
BUG=700607
[1] https://w3c.github.io/mediacapture-image/##photocapabilities-section
[2] https://w3c.github.io/mediacapture-image/##photosettings-section
[3] https://w3c.github.io/mediacapture-image/#additional-constrainable-props

Review-Url: https://codereview.chromium.org/2773593004
Cr-Commit-Position: refs/heads/master@{#459367}
Committed: https://chromium.googlesource.com/chromium/src/+/7f9e2de323e9265aee33ba9683ba98b09fec6769

[mcasas, 2017-03-23 20:36:03]

Description was changed from

==========
Image Capture: moar [wip]



Added file for ConstrainPoint2DParameters.idl


Removed from PhotoCapabilities and PhotoSettings the fields that are supposed to
be only in MediaStreamTrack

BUG=700607
==========

to

==========
Image Capture: prune Photo{Capabilities/Settings} and add pointsOfInterest

This CL removes from PhotoCapabilities.idl the fields that are
not there anymore according to the spec [1], leaving just four 
of them.  The correspondent code and LayoutTests is updated.
Same for PhotoSettings.idl [2].

This CL also adds ConstrainPoint2D data type [3] and uses it
for MediaTrackConstraintSet.pointsOfInterest, wiring it down 
to the mojo interface and in the mock.

This is the one and only change visible to the users. There is
an Origin Trial going on for Image Capture in M56-57-58, but
this changes will land in 59.x.y.z, so shouldn't affect them, and
in any case an update to blink-dev@ is being brewed and
there's a migration guide:
  https://tinyurl.com/image-capture-migration-guide

TEST= Layouttests etc updated.
BUG=700607

[1] https://w3c.github.io/mediacapture-image/##photocapabilities-section
[2] https://w3c.github.io/mediacapture-image/##photosettings-section
[3] https://w3c.github.io/mediacapture-image/#additional-constrainable-props
==========

[mcasas, 2017-03-23 20:37:50]

Description was changed from

==========
Image Capture: prune Photo{Capabilities/Settings} and add pointsOfInterest

This CL removes from PhotoCapabilities.idl the fields that are
not there anymore according to the spec [1], leaving just four 
of them.  The correspondent code and LayoutTests is updated.
Same for PhotoSettings.idl [2].

This CL also adds ConstrainPoint2D data type [3] and uses it
for MediaTrackConstraintSet.pointsOfInterest, wiring it down 
to the mojo interface and in the mock.

This is the one and only change visible to the users. There is
an Origin Trial going on for Image Capture in M56-57-58, but
this changes will land in 59.x.y.z, so shouldn't affect them, and
in any case an update to blink-dev@ is being brewed and
there's a migration guide:
  https://tinyurl.com/image-capture-migration-guide

TEST= Layouttests etc updated.
BUG=700607

[1] https://w3c.github.io/mediacapture-image/##photocapabilities-section
[2] https://w3c.github.io/mediacapture-image/##photosettings-section
[3] https://w3c.github.io/mediacapture-image/#additional-constrainable-props
==========

to

==========
Image Capture: prune Photo{Capabilities/Settings} and add pointsOfInterest

- This CL removes from PhotoCapabilities.idl the fields that are
not there anymore according to the spec [1], leaving just four 
of them.  The correspondent code and LayoutTests is updated.
Same for PhotoSettings.idl [2].

- This CL also adds ConstrainPoint2D data type [3] and uses it
for MediaTrackConstraintSet.pointsOfInterest, wiring it down 
to the mojo interface and in the mock.

- This is the one and only important change visible to the users. 
(There is an Origin Trial going on for Image Capture in 
M56-57-58, but these changes will land in 59.x.y.z, so shouldn't 
affect them, in any case an update to blink-dev@ is being 
brewed and there's a migration guide:
  https://tinyurl.com/image-capture-migration-guide
)

- No more MediaStreamTrack idl changes are expected after
this CL \o/


TEST= Layouttests etc updated.
BUG=700607

[1] https://w3c.github.io/mediacapture-image/##photocapabilities-section
[2] https://w3c.github.io/mediacapture-image/##photosettings-section
[3] https://w3c.github.io/mediacapture-image/#additional-constrainable-props
==========

[mcasas, 2017-03-23 20:42:49]

Patchset #1 (id:1) has been deleted

[mcasas, 2017-03-23 21:20:58]

Description was changed from

==========
Image Capture: prune Photo{Capabilities/Settings} and add pointsOfInterest

- This CL removes from PhotoCapabilities.idl the fields that are
not there anymore according to the spec [1], leaving just four 
of them.  The correspondent code and LayoutTests is updated.
Same for PhotoSettings.idl [2].

- This CL also adds ConstrainPoint2D data type [3] and uses it
for MediaTrackConstraintSet.pointsOfInterest, wiring it down 
to the mojo interface and in the mock.

- This is the one and only important change visible to the users. 
(There is an Origin Trial going on for Image Capture in 
M56-57-58, but these changes will land in 59.x.y.z, so shouldn't 
affect them, in any case an update to blink-dev@ is being 
brewed and there's a migration guide:
  https://tinyurl.com/image-capture-migration-guide
)

- No more MediaStreamTrack idl changes are expected after
this CL \o/


TEST= Layouttests etc updated.
BUG=700607

[1] https://w3c.github.io/mediacapture-image/##photocapabilities-section
[2] https://w3c.github.io/mediacapture-image/##photosettings-section
[3] https://w3c.github.io/mediacapture-image/#additional-constrainable-props
==========

to

==========
Image Capture: prune Photo{Capabilities/Settings} and add
MediaTrackConstraintSet.pointsOfInterest

- This CL removes from PhotoCapabilities.idl the fields that are
not there anymore according to the spec [1], leaving just four 
of them.  The correspondent code and LayoutTests is updated.
Same for PhotoSettings.idl [2].

- This CL also adds ConstrainPoint2D data type [3] and uses it
for MediaTrackConstraintSet.pointsOfInterest, wiring it down 
to the mojo interface and in the mock.

- This is the one and only important change visible to the users. 
(There is an Origin Trial going on for Image Capture in 
M56-57-58, but these changes will land in 59.x.y.z, so shouldn't 
affect them, in any case an update to blink-dev@ is being 
brewed and there's a migration guide:
  https://tinyurl.com/image-capture-migration-guide
)

- No more MediaStreamTrack idl changes are expected after
this CL \o/


TEST= Layouttests etc updated.
BUG=700607

[1] https://w3c.github.io/mediacapture-image/##photocapabilities-section
[2] https://w3c.github.io/mediacapture-image/##photosettings-section
[3] https://w3c.github.io/mediacapture-image/#additional-constrainable-props
==========

[mcasas, 2017-03-23 21:22:42]

mcasas@chromium.org changed reviewers:
+ guidou@chromium.org, haraken@chromium.org, reillyg@chromium.org

[mcasas, 2017-03-23 21:22:42]

reillyg@ PTAL at the removals and (small) changes.

haraken@ RS plz the addition of idl files to gni's etc

guidou@ RS plz minor additions to MediaTrackConstraintSet.idl

[mcasas, 2017-03-23 22:24:52]

Patchset #1 (id:20001) has been deleted

[Guido Urdaneta, 2017-03-23 22:59:04]

mediastream lgtm

[Reilly Grant (use Gerrit), 2017-03-23 23:24:00]

Description was changed from

==========
Image Capture: prune Photo{Capabilities/Settings} and add
MediaTrackConstraintSet.pointsOfInterest

- This CL removes from PhotoCapabilities.idl the fields that are
not there anymore according to the spec [1], leaving just four 
of them.  The correspondent code and LayoutTests is updated.
Same for PhotoSettings.idl [2].

- This CL also adds ConstrainPoint2D data type [3] and uses it
for MediaTrackConstraintSet.pointsOfInterest, wiring it down 
to the mojo interface and in the mock.

- This is the one and only important change visible to the users. 
(There is an Origin Trial going on for Image Capture in 
M56-57-58, but these changes will land in 59.x.y.z, so shouldn't 
affect them, in any case an update to blink-dev@ is being 
brewed and there's a migration guide:
  https://tinyurl.com/image-capture-migration-guide
)

- No more MediaStreamTrack idl changes are expected after
this CL \o/


TEST= Layouttests etc updated.
BUG=700607

[1] https://w3c.github.io/mediacapture-image/##photocapabilities-section
[2] https://w3c.github.io/mediacapture-image/##photosettings-section
[3] https://w3c.github.io/mediacapture-image/#additional-constrainable-props
==========

to

==========
Image Capture: prune Photo{Capabilities/Settings} and add
MediaTrackConstraintSet.pointsOfInterest

- This CL removes from PhotoCapabilities.idl the fields that are
not there anymore according to the spec [1], leaving just four 
of them.  The corresponding code and LayoutTests are updated.
Same for PhotoSettings.idl [2].

- This CL also adds ConstrainPoint2D data type [3] and uses it
for MediaTrackConstraintSet.pointsOfInterest, wiring it down 
to the mojo interface and in the mock.

- This is the one and only important change visible to the users. 
(There is an Origin Trial going on for Image Capture in 
M56-57-58, but these changes will land in 59.x.y.z, so shouldn't 
affect them, in any case an update to blink-dev@ is being 
brewed and there's a migration guide:
  https://tinyurl.com/image-capture-migration-guide
)

- No more MediaStreamTrack idl changes are expected after
this CL \o/


TEST= Layouttests etc updated.
BUG=700607

[1] https://w3c.github.io/mediacapture-image/##photocapabilities-section
[2] https://w3c.github.io/mediacapture-image/##photosettings-section
[3] https://w3c.github.io/mediacapture-image/#additional-constrainable-props
==========

[mcasas, 2017-03-23 23:42:21]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 23:43:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2017-03-23 23:58:48]

lgtm with nits

https://codereview.chromium.org/2773593004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl
(right):

https://codereview.chromium.org/2773593004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl:5: //
https://www.w3.org/TR/image-capture/#PhotoCapabilities
This should probably point to
https://w3c.github.io/mediacapture-image/##photocapabilities-section because
what is here reflects the ED and not the WD.

https://codereview.chromium.org/2773593004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/imagecapture/PhotoSettings.idl (right):

https://codereview.chromium.org/2773593004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/imagecapture/PhotoSettings.idl:5: //
https://www.w3.org/TR/image-capture/#PhotoSettings
Same here.

[commit-bot: I haz the power, 2017-03-24 00:37:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 00:37:51]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-03-24 00:40:38]

LGTM

[mcasas, 2017-03-24 01:09:35]

https://codereview.chromium.org/2773593004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl
(right):

https://codereview.chromium.org/2773593004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl:5: //
https://www.w3.org/TR/image-capture/#PhotoCapabilities
On 2017/03/23 23:58:48, Reilly Grant wrote:
> This should probably point to
> https://w3c.github.io/mediacapture-image/##photocapabilities-section because
> what is here reflects the ED and not the WD.

Done.

https://codereview.chromium.org/2773593004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/imagecapture/PhotoSettings.idl (right):

https://codereview.chromium.org/2773593004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/imagecapture/PhotoSettings.idl:5: //
https://www.w3.org/TR/image-capture/#PhotoSettings
On 2017/03/23 23:58:48, Reilly Grant wrote:
> Same here.

Done.

[mcasas, 2017-03-24 01:09:43]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 01:10:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 03:55:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 03:55:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mcasas, 2017-03-24 04:21:55]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2017-03-24 04:21:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, guidou@chromium.org, reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2773593004/#ps60001
(title: "reillyg@ comments on idl urls.")

[commit-bot: I haz the power, 2017-03-24 04:22:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 05:47:31]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490329315612910,
"parent_rev": "b3e59c4efa72120f82d4f67d7097fab634d6157f", "commit_rev":
"7f9e2de323e9265aee33ba9683ba98b09fec6769"}

[commit-bot: I haz the power, 2017-03-24 05:48:53]

Description was changed from

==========
Image Capture: prune Photo{Capabilities/Settings} and add
MediaTrackConstraintSet.pointsOfInterest

- This CL removes from PhotoCapabilities.idl the fields that are
not there anymore according to the spec [1], leaving just four 
of them.  The corresponding code and LayoutTests are updated.
Same for PhotoSettings.idl [2].

- This CL also adds ConstrainPoint2D data type [3] and uses it
for MediaTrackConstraintSet.pointsOfInterest, wiring it down 
to the mojo interface and in the mock.

- This is the one and only important change visible to the users. 
(There is an Origin Trial going on for Image Capture in 
M56-57-58, but these changes will land in 59.x.y.z, so shouldn't 
affect them, in any case an update to blink-dev@ is being 
brewed and there's a migration guide:
  https://tinyurl.com/image-capture-migration-guide
)

- No more MediaStreamTrack idl changes are expected after
this CL \o/


TEST= Layouttests etc updated.
BUG=700607

[1] https://w3c.github.io/mediacapture-image/##photocapabilities-section
[2] https://w3c.github.io/mediacapture-image/##photosettings-section
[3] https://w3c.github.io/mediacapture-image/#additional-constrainable-props
==========

to

==========
Image Capture: prune Photo{Capabilities/Settings} and add
MediaTrackConstraintSet.pointsOfInterest

- This CL removes from PhotoCapabilities.idl the fields that are
not there anymore according to the spec [1], leaving just four 
of them.  The corresponding code and LayoutTests are updated.
Same for PhotoSettings.idl [2].

- This CL also adds ConstrainPoint2D data type [3] and uses it
for MediaTrackConstraintSet.pointsOfInterest, wiring it down 
to the mojo interface and in the mock.

- This is the one and only important change visible to the users. 
(There is an Origin Trial going on for Image Capture in 
M56-57-58, but these changes will land in 59.x.y.z, so shouldn't 
affect them, in any case an update to blink-dev@ is being 
brewed and there's a migration guide:
  https://tinyurl.com/image-capture-migration-guide
)

- No more MediaStreamTrack idl changes are expected after
this CL \o/


TEST= Layouttests etc updated.
BUG=700607

[1] https://w3c.github.io/mediacapture-image/##photocapabilities-section
[2] https://w3c.github.io/mediacapture-image/##photosettings-section
[3] https://w3c.github.io/mediacapture-image/#additional-constrainable-props

Review-Url: https://codereview.chromium.org/2773593004
Cr-Commit-Position: refs/heads/master@{#459367}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f9e2de323e9265aee33ba9683ba...
==========

[commit-bot: I haz the power, 2017-03-24 05:48:56]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7f9e2de323e9265aee33ba9683ba...