Revert of Extensions: Only create Web request rules registry if Declarative Web Request is enabled.

Revert of Extensions: Only create Web request rules registry if Declarative Web Request is enabled. (patchset #4 id:60001 of https://codereview.chromium.org/2705513002/ )

Reason for revert:
Declarative Web Request is enabled on Stable through <webview>. Hence we can't disable creation of rules registry on Stable.

Original issue's description:
> Extensions: Only create Web request rules registry if Declarative Web Request is enabled.
> 
> Currently the Web Request rules registry required by the Declarative Web
> Request API is created on all Chrome channels, even though the Declarative Web
> Request API is disabled on Stable. The UMA metric
> Extensions.NetworkDelayRegistryLoad shows significant delay for some web
> requests which are blocked due to the loading of the Web Request rules
> registry even on Stable. The mean delay is around 1.7 sec and the median delay
> is around 50ms.
> 
> This CL modifies RulesRegistryService::EnsureDefaultRulesRegistriesRegistered
> to ensure the Web Request rules registry is only created for the channels on
> which the Declarative Web Request API is enabled. To do this,
> Feature::IsAvailableToChannel is introduced.
> 
> BUG=693243
> 
> Review-Url: https://codereview.chromium.org/2705513002
> Cr-Commit-Position: refs/heads/master@{#452240}
> Committed: https://chromium.googlesource.com/chromium/src/+/a77b53baca5f2a4ff102592c17c8ea3f53dd5307

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=693243
Review-Url: https://codereview.chromium.org/2773593003
Cr-Commit-Position: refs/heads/master@{#459269}
Committed: https://chromium.googlesource.com/chromium/src/+/9df2cccc337ca57188f9709b2205439347870606

[karandeepb, 2017-03-23 18:20:30]

Created Revert of Extensions: Only create Web request rules registry if
Declarative Web Request is enabled.

[karandeepb, 2017-03-23 18:21:21]

Description was changed from

==========
Revert of Extensions: Only create Web request rules registry if Declarative Web
Request is enabled. (patchset #4 id:60001 of
https://codereview.chromium.org/2705513002/ )

Reason for revert:
Declarative Web Request is enabled on Stable through <webview>. Hence we can't
disable creation of rules registry on Stable.

Original issue's description:
> Extensions: Only create Web request rules registry if Declarative Web Request
is enabled.
> 
> Currently the Web Request rules registry required by the Declarative Web
> Request API is created on all Chrome channels, even though the Declarative Web
> Request API is disabled on Stable. The UMA metric
> Extensions.NetworkDelayRegistryLoad shows significant delay for some web
> requests which are blocked due to the loading of the Web Request rules
> registry even on Stable. The mean delay is around 1.7 sec and the median delay
> is around 50ms.
> 
> This CL modifies RulesRegistryService::EnsureDefaultRulesRegistriesRegistered
> to ensure the Web Request rules registry is only created for the channels on
> which the Declarative Web Request API is enabled. To do this,
> Feature::IsAvailableToChannel is introduced.
> 
> BUG=693243
> 
> Review-Url: https://codereview.chromium.org/2705513002
> Cr-Commit-Position: refs/heads/master@{#452240}
> Committed:
https://chromium.googlesource.com/chromium/src/+/a77b53baca5f2a4ff102592c17c8...

TBR=rdevlin.cronin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=693243
==========

to

==========
Revert of Extensions: Only create Web request rules registry if Declarative Web
Request is enabled. (patchset #4 id:60001 of
https://codereview.chromium.org/2705513002/ )

Reason for revert:
Declarative Web Request is enabled on Stable through <webview>. Hence we can't
disable creation of rules registry on Stable.

Original issue's description:
> Extensions: Only create Web request rules registry if Declarative Web Request
is enabled.
> 
> Currently the Web Request rules registry required by the Declarative Web
> Request API is created on all Chrome channels, even though the Declarative Web
> Request API is disabled on Stable. The UMA metric
> Extensions.NetworkDelayRegistryLoad shows significant delay for some web
> requests which are blocked due to the loading of the Web Request rules
> registry even on Stable. The mean delay is around 1.7 sec and the median delay
> is around 50ms.
> 
> This CL modifies RulesRegistryService::EnsureDefaultRulesRegistriesRegistered
> to ensure the Web Request rules registry is only created for the channels on
> which the Declarative Web Request API is enabled. To do this,
> Feature::IsAvailableToChannel is introduced.
> 
> BUG=693243
> 
> Review-Url: https://codereview.chromium.org/2705513002
> Cr-Commit-Position: refs/heads/master@{#452240}
> Committed:
https://chromium.googlesource.com/chromium/src/+/a77b53baca5f2a4ff102592c17c8...

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=693243
==========

[karandeepb, 2017-03-23 18:22:06]

On 2017/03/23 18:20:30, karandeepb wrote:
> Created Revert of Extensions: Only create Web request rules registry if
> Declarative Web Request is enabled.

Removed the TBR. PTAL Devlin.

[Devlin, 2017-03-23 21:45:11]

On 2017/03/23 18:22:06, karandeepb wrote:
> On 2017/03/23 18:20:30, karandeepb wrote:
> > Created Revert of Extensions: Only create Web request rules registry if
> > Declarative Web Request is enabled.
> 
> Removed the TBR. PTAL Devlin.

lgtm

[karandeepb, 2017-03-23 22:23:51]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2017-03-23 22:24:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 23:12:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490307831428820, "parent_rev":
"97b246bbe8983a578c9bc2896b2fbb4cd54683aa", "commit_rev":
"9df2cccc337ca57188f9709b2205439347870606"}

[commit-bot: I haz the power, 2017-03-23 23:13:27]

Description was changed from

==========
Revert of Extensions: Only create Web request rules registry if Declarative Web
Request is enabled. (patchset #4 id:60001 of
https://codereview.chromium.org/2705513002/ )

Reason for revert:
Declarative Web Request is enabled on Stable through <webview>. Hence we can't
disable creation of rules registry on Stable.

Original issue's description:
> Extensions: Only create Web request rules registry if Declarative Web Request
is enabled.
> 
> Currently the Web Request rules registry required by the Declarative Web
> Request API is created on all Chrome channels, even though the Declarative Web
> Request API is disabled on Stable. The UMA metric
> Extensions.NetworkDelayRegistryLoad shows significant delay for some web
> requests which are blocked due to the loading of the Web Request rules
> registry even on Stable. The mean delay is around 1.7 sec and the median delay
> is around 50ms.
> 
> This CL modifies RulesRegistryService::EnsureDefaultRulesRegistriesRegistered
> to ensure the Web Request rules registry is only created for the channels on
> which the Declarative Web Request API is enabled. To do this,
> Feature::IsAvailableToChannel is introduced.
> 
> BUG=693243
> 
> Review-Url: https://codereview.chromium.org/2705513002
> Cr-Commit-Position: refs/heads/master@{#452240}
> Committed:
https://chromium.googlesource.com/chromium/src/+/a77b53baca5f2a4ff102592c17c8...

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=693243
==========

to

==========
Revert of Extensions: Only create Web request rules registry if Declarative Web
Request is enabled. (patchset #4 id:60001 of
https://codereview.chromium.org/2705513002/ )

Reason for revert:
Declarative Web Request is enabled on Stable through <webview>. Hence we can't
disable creation of rules registry on Stable.

Original issue's description:
> Extensions: Only create Web request rules registry if Declarative Web Request
is enabled.
> 
> Currently the Web Request rules registry required by the Declarative Web
> Request API is created on all Chrome channels, even though the Declarative Web
> Request API is disabled on Stable. The UMA metric
> Extensions.NetworkDelayRegistryLoad shows significant delay for some web
> requests which are blocked due to the loading of the Web Request rules
> registry even on Stable. The mean delay is around 1.7 sec and the median delay
> is around 50ms.
> 
> This CL modifies RulesRegistryService::EnsureDefaultRulesRegistriesRegistered
> to ensure the Web Request rules registry is only created for the channels on
> which the Declarative Web Request API is enabled. To do this,
> Feature::IsAvailableToChannel is introduced.
> 
> BUG=693243
> 
> Review-Url: https://codereview.chromium.org/2705513002
> Cr-Commit-Position: refs/heads/master@{#452240}
> Committed:
https://chromium.googlesource.com/chromium/src/+/a77b53baca5f2a4ff102592c17c8...

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=693243

Review-Url: https://codereview.chromium.org/2773593003
Cr-Commit-Position: refs/heads/master@{#459269}
Committed:
https://chromium.googlesource.com/chromium/src/+/9df2cccc337ca57188f9709b2205...
==========

[commit-bot: I haz the power, 2017-03-23 23:13:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9df2cccc337ca57188f9709b2205...