Stop passing raw pointers to DictionaryValue::Set, part 1

Stop passing raw pointers to DictionaryValue::Set, part 1

base::Value API has alternatives with unique_ptr, and passing ownership with
raw pointers can hide bugs. Therefore, this CL migrates a portion of Chromium
code to use the unique_ptr-based API.

BUG=697817
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=finnur@chromium.org

Review-Url: https://codereview.chromium.org/2773513002
Cr-Commit-Position: refs/heads/master@{#459164}
Committed: https://chromium.googlesource.com/chromium/src/+/bce355c4052c6a9c3863c355a7150b4df8f08b0c

[vabr (Chromium), 2017-03-22 20:41:08]

Description was changed from

==========
Stop passing raw pointers to DictionaryValue::Set, part 1

base::Value API has alternatives with unique_ptr, and passing ownership with
raw pointers can hide bugs. Therefore, this CL migrates a portion of Chromium
code to use the unique_ptr-based API.

BUG=697817
==========

to

==========
Stop passing raw pointers to DictionaryValue::Set, part 1

base::Value API has alternatives with unique_ptr, and passing ownership with
raw pointers can hide bugs. Therefore, this CL migrates a portion of Chromium
code to use the unique_ptr-based API.

BUG=697817
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vabr (Chromium), 2017-03-22 20:53:16]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 20:54:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-03-22 21:07:58]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 21:08:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 22:22:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 22:22:09]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2017-03-22 22:31:36]

vabr@chromium.org changed reviewers:
+ danakj@chromium.org, pam@chromium.org

[vabr (Chromium), 2017-03-22 22:31:37]

Hi danakj@ and pam@,

Could you please review the following?

pam@ -- components/prefs/*

danakj@ -- cc/* and base/*

Thanks!
Vaclav

[vabr (Chromium), 2017-03-22 22:38:01]

vabr@chromium.org changed reviewers:
+ derat@chromium.org, finnur@chromium.org, qinmin@chromium.org

[vabr (Chromium), 2017-03-22 22:38:02]

Asking more OWNERs for review:

derat@ -- ash/touch/touch_hud_debug.cc

qinmin@ -- chrome/browser/download/download_target_determiner_unittest.cc

finnur@ -- chrome/browser/extensions/api/file_system/file_system_api.cc

Thanks!
Vaclav

[Daniel Erat, 2017-03-22 22:41:13]

lgtm for ash/

[qinmin, 2017-03-23 06:10:56]

lgtm

[Pam (message me for reviews), 2017-03-23 15:10:16]

On 2017/03/23 06:10:56, qinmin wrote:
> lgtm

prefs/ LGTM

[danakj, 2017-03-23 15:18:19]

base and cc LGTM

[vabr (Chromium), 2017-03-23 18:41:28]

Thanks, all!

Finnur, the change in
chrome/browser/extensions/api/file_system/file_system_api.cc is very simple and
a mechanical consequence of the rest of the CL. I will TBR you for that.

Sending to CQ now.

Cheers,
Vaclav

[vabr (Chromium), 2017-03-23 18:42:13]

Description was changed from

==========
Stop passing raw pointers to DictionaryValue::Set, part 1

base::Value API has alternatives with unique_ptr, and passing ownership with
raw pointers can hide bugs. Therefore, this CL migrates a portion of Chromium
code to use the unique_ptr-based API.

BUG=697817
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Stop passing raw pointers to DictionaryValue::Set, part 1

base::Value API has alternatives with unique_ptr, and passing ownership with
raw pointers can hide bugs. Therefore, this CL migrates a portion of Chromium
code to use the unique_ptr-based API.

BUG=697817
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=finnur@chromium.org
==========

[vabr (Chromium), 2017-03-23 18:42:37]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2017-03-23 18:43:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 18:52:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490294557155940,
"parent_rev": "98433eb88008c7ecb49f4db350c2ab5db60b1bb2", "commit_rev":
"bce355c4052c6a9c3863c355a7150b4df8f08b0c"}

[commit-bot: I haz the power, 2017-03-23 18:53:29]

Description was changed from

==========
Stop passing raw pointers to DictionaryValue::Set, part 1

base::Value API has alternatives with unique_ptr, and passing ownership with
raw pointers can hide bugs. Therefore, this CL migrates a portion of Chromium
code to use the unique_ptr-based API.

BUG=697817
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=finnur@chromium.org
==========

to

==========
Stop passing raw pointers to DictionaryValue::Set, part 1

base::Value API has alternatives with unique_ptr, and passing ownership with
raw pointers can hide bugs. Therefore, this CL migrates a portion of Chromium
code to use the unique_ptr-based API.

BUG=697817
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=finnur@chromium.org

Review-Url: https://codereview.chromium.org/2773513002
Cr-Commit-Position: refs/heads/master@{#459164}
Committed:
https://chromium.googlesource.com/chromium/src/+/bce355c4052c6a9c3863c355a715...
==========

[commit-bot: I haz the power, 2017-03-23 18:53:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bce355c4052c6a9c3863c355a715...

[Finnur, 2017-03-24 09:46:13]

> I will TBR you for that.

Not a problem. LGTM.