Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2773493002: [Merge M58] arc: Fix regression in handling ARC shelf item. (Closed)

Created:
3 years, 9 months ago by khmel
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge M58] arc: Fix regression in handling ARC shelf item. This fix regressions caused by recent refactoring. First regression is in case multiple shelf items for the same ARC app, clicking on shelf item always activates last opened window. It is expected that in this case last active window of that app becomes active. Second one, selecting which item to activate from menu does not actually activate selected item BUG=703895 TEST=Manually, unit_tests extended. NOTRY=true NOPRESUBMIT=true TBR=msw@chromium.org Review-Url: https://codereview.chromium.org/2763893004 Cr-Commit-Position: refs/heads/master@{#458638} (cherry picked from commit a19209825989de7d6b620aea95dd0f95b5c3c03f) Review-Url: https://codereview.chromium.org/2773493002 Cr-Commit-Position: refs/branch-heads/3029@{#377} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/e62cb970ec7675219a52e1f529136335fc95970d

Patch Set 1 #

Patch Set 2 : resolve merge conflicts and adopt to M58 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 3 chunks +66 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
khmel
passed locally unit_tests + manually tested on device
3 years, 9 months ago (2017-03-23 01:14:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773493002/20001
3 years, 9 months ago (2017-03-23 01:14:44 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 9 months ago (2017-03-23 01:14:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773493002/20001
3 years, 9 months ago (2017-03-23 01:42:57 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 01:45:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e62cb970ec7675219a52e1f52913...

Powered by Google App Engine
This is Rietveld 408576698