Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 2773483003: Create PasswordProtectionRequest to handle password pings (Closed)
Patch Set: fix SB cookie test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc
index e34d9d9c323e7baca55792874f4fd5fd66567d6a..43911bd6860a97c3c3d1850b2d51dd30e53316b8 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc
@@ -334,8 +334,8 @@ void SafeBrowsingService::Initialize() {
// TODO(jialiul): When PasswordProtectionService does more than reporting UMA,
// we need to add finch trial to gate its functionality.
- password_protection_service_ =
- base::MakeUnique<PasswordProtectionService>(database_manager());
+ password_protection_service_ = base::MakeUnique<PasswordProtectionService>(
+ database_manager(), url_request_context());
// Track the safe browsing preference of existing profiles.
// The SafeBrowsingService will be started if any existing profile has the
@@ -378,6 +378,8 @@ void SafeBrowsingService::ShutDown() {
services_delegate_->ShutdownServices();
+ password_protection_service_.reset();
Nathan Parker 2017/03/23 20:45:49 Maybe this should go before services_delegate sinc
Jialiu Lin 2017/03/23 22:42:58 Done.
+
// Since URLRequestContextGetters are refcounted, can't count on clearing
// |url_request_context_getter_| to delete it, so need to shut it down first,
// which will cancel any requests that are currently using it, and prevent

Powered by Google App Engine
This is Rietveld 408576698