Create PasswordProtectionRequest to handle password pings

chrome/browser/safe_browsing/safe_browsing_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 
 #include <stddef.h>
 
 #include <vector>
 
@@ skipping 316 matching lines @@
   if (base::FeatureList::IsEnabled(
     SafeBrowsingNavigationObserverManager::kDownloadAttribution)) {
     navigation_observer_manager_ = new SafeBrowsingNavigationObserverManager();
   }
 
   services_delegate_->Initialize(v4_enabled_);
   services_delegate_->InitializeCsdService(url_request_context_getter_.get());
 
   // TODO(jialiul): When PasswordProtectionService does more than reporting UMA,
   // we need to add finch trial to gate its functionality.
-  password_protection_service_ =
-      base::MakeUnique<PasswordProtectionService>(database_manager());
+  password_protection_service_ = base::MakeUnique<PasswordProtectionService>(
+      database_manager(), url_request_context());
 
   // Track the safe browsing preference of existing profiles.
   // The SafeBrowsingService will be started if any existing profile has the
   // preference enabled. It will also listen for updates to the preferences.
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   if (profile_manager) {
     std::vector<Profile*> profiles = profile_manager->GetLoadedProfiles();
     // TODO(felt): I believe this for-loop is dead code. Confirm this and
     // remove in a future CL. See https://codereview.chromium.org/1341533002/
     DCHECK_EQ(0u, profiles.size());
@@ skipping 22 matching lines @@
   // observer of the preferences.
   prefs_map_.clear();
 
   // Remove Profile creation/destruction observers.
   prefs_registrar_.RemoveAll();
 
   Stop(true);
 
   services_delegate_->ShutdownServices();
 
+  password_protection_service_.reset();

[Nathan Parker, 2017/03/23 20:45:49]

Maybe this should go before services_delegate since that way it's the opposite
order of creation. PPS might depend on things in services_delegate_.

[Jialiu Lin, 2017/03/23 22:42:58]

Done.

+
   // Since URLRequestContextGetters are refcounted, can't count on clearing
   // |url_request_context_getter_| to delete it, so need to shut it down first,
   // which will cancel any requests that are currently using it, and prevent
   // new requests from using it as well.
   BrowserThread::PostNonNestableTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&SafeBrowsingURLRequestContextGetter::ServiceShuttingDown,
                  url_request_context_getter_));
 
   // Release the URLRequestContextGetter after passing it to the IOThread.  It
@@ skipping 376 matching lines @@
     ping_manager()->ReportThreatDetails(report);
 }
 
 void SafeBrowsingService::ProcessResourceRequest(
     const ResourceRequestInfo& request) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   services_delegate_->ProcessResourceRequest(&request);
 }
 
 }  // namespace safe_browsing