Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2773473003:
cros: Add CHECK to ShelfWidget initialization enabling future cleanup. (Closed)
|
Created:
3 years, 9 months ago by jdufault Modified:
3 years, 9 months ago Reviewers:
James Cook CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptioncros: Add CHECK to ShelfWidget initialization enabling future cleanup.
BUG=701157
Review-Url: https://codereview.chromium.org/2773473003
Cr-Commit-Position: refs/heads/master@{#459123}
Committed: https://chromium.googlesource.com/chromium/src/+/c01d07dff75c0e7aeb8ef9f792652d32f1fd8957
Patch Set 1 : Initial upload #
Messages
Total messages: 18 (14 generated)
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:1) has been deleted
Description was changed from ========== cros: Add CHECK to ShelfWidget initialization enabling future cleanup. BUG=701157 ========== to ========== cros: Add CHECK to ShelfWidget initialization enabling future cleanup. BUG=701157 ==========
jdufault@chromium.org changed reviewers: + jamescook@chromium.org
jamescook@ PTAL.
lgtm
The CQ bit was checked by jdufault@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490288004962290,
"parent_rev": "82d783b49d98c2d4050c43f336b3116cf4b322c5", "commit_rev":
"c01d07dff75c0e7aeb8ef9f792652d32f1fd8957"}
Message was sent while issue was closed.
Description was changed from ========== cros: Add CHECK to ShelfWidget initialization enabling future cleanup. BUG=701157 ========== to ========== cros: Add CHECK to ShelfWidget initialization enabling future cleanup. BUG=701157 Review-Url: https://codereview.chromium.org/2773473003 Cr-Commit-Position: refs/heads/master@{#459123} Committed: https://chromium.googlesource.com/chromium/src/+/c01d07dff75c0e7aeb8ef9f79265... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c01d07dff75c0e7aeb8ef9f79265... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
