Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2773473002:
Use TaskScheduler instead of blocking pool in feedback_data.cc. (Closed)
DescriptionUse TaskScheduler instead of blocking pool in feedback_data.cc.
The blocking pool is being deprecated in favor of TaskScheduler.
BUG=667892
R=steel@chromium.org
Review-Url: https://codereview.chromium.org/2773473002
Cr-Commit-Position: refs/heads/master@{#469025}
Committed: https://chromium.googlesource.com/chromium/src/+/d8bc5fe8ad10e20a98bc0f35ee9010938c0771b8
Patch Set 1 #Patch Set 2 : mayblock #
Total comments: 2
Patch Set 3 : MayBlock #Messages
Total messages: 30 (20 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
PTAL! This CL was generated automatically. Please make sure that the appropriate TaskTraits are used to post tasks. https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h If everything looks good, please lgtm and CQ this CL. Otherwise, tell us what's wrong. Thanks! - FAQ - What if bots are red? Ignore this CL. A human will look at errors shortly. What if the task priority is not set explicitly (no .WithTaskPriority)? When there is no explicit priority, the priority is inherited from the calling context (e.g. a task posted from a BACKGROUND task without an explicit priority will have a BACKGROUND priority). What if the shutdown behavior is not set explicitly (no .WithShutdownBehavior)? If shutdown behavior is important for a task, it should be set explicitly. It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or SKIP_ON_SHUTDOWN.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Please take a look On 2017/03/22 19:34:10, fdoray wrote: > PTAL! > > This CL was generated automatically. > > Please make sure that the appropriate TaskTraits are used to post tasks. > https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h > If everything looks good, please lgtm and CQ this CL. Otherwise, tell > us what's wrong. > > Thanks! > > - FAQ - > > What if bots are red? Ignore this CL. A human will look at errors shortly. > > What if the task priority is not set explicitly (no .WithTaskPriority)? > When there is no explicit priority, the priority is inherited from the > calling context (e.g. a task posted from a BACKGROUND task without an > explicit priority will have a BACKGROUND priority). > > What if the shutdown behavior is not set explicitly (no .WithShutdownBehavior)? > If shutdown behavior is important for a task, it should be set explicitly. > It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN > or SKIP_ON_SHUTDOWN.
fdoray@chromium.org changed reviewers: + rkc@chromium.org
steel@ -> rkc@ Please take a look
rkc@chromium.org changed reviewers: + afakhry@chromium.org
lg to me, but Ahmed should be really looking at this.
https://codereview.chromium.org/2773473002/diff/20001/components/feedback/fee... File components/feedback/feedback_data.cc (right): https://codereview.chromium.org/2773473002/diff/20001/components/feedback/fee... components/feedback/feedback_data.cc:69: base::TaskTraits().WithPriority(base::TaskPriority::BACKGROUND), Why doesn't this have the .MayBlock() like the other ones?
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Please take another look https://codereview.chromium.org/2773473002/diff/20001/components/feedback/fee... File components/feedback/feedback_data.cc (right): https://codereview.chromium.org/2773473002/diff/20001/components/feedback/fee... components/feedback/feedback_data.cc:69: base::TaskTraits().WithPriority(base::TaskPriority::BACKGROUND), On 2017/05/03 16:38:36, afakhry wrote: > Why doesn't this have the .MayBlock() like the other ones? Done.
lgtm
The CQ bit was unchecked by fdoray@chromium.org
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493829853543110,
"parent_rev": "e438b70bdaeaa556a261916ead0e6286f4c077bf", "commit_rev":
"d8bc5fe8ad10e20a98bc0f35ee9010938c0771b8"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of blocking pool in feedback_data.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=steel@chromium.org ========== to ========== Use TaskScheduler instead of blocking pool in feedback_data.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=steel@chromium.org Review-Url: https://codereview.chromium.org/2773473002 Cr-Commit-Position: refs/heads/master@{#469025} Committed: https://chromium.googlesource.com/chromium/src/+/d8bc5fe8ad10e20a98bc0f35ee90... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/d8bc5fe8ad10e20a98bc0f35ee90... |
