Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2773423002: Revert of Remove sandbox/win/tools. (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
Nico, Will Harris
CC:
chromium-reviews, wfh+watch_chromium.org, pennymac+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove sandbox/win/tools. (patchset #1 id:1 of https://codereview.chromium.org/2773333002/ ) Reason for revert: Broke WinClang64 dbg build. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWinClang64__dbg_%2F11236%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout C:\b\c\b\win_clang\src\sandbox\win\sandbox_poc\pocdll\handles.cc(7,10): fatal error: 'sandbox/win/tools/finder/ntundoc.h' file not found #include "sandbox/win/tools/finder/ntundoc.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original issue's description: > Remove sandbox/win/tools. > > The files therein look unused, haven't been really touched since 2012, aren't > referenced in any build files, and have some maintenance cost. > > BUG=661774 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng > > Review-Url: https://codereview.chromium.org/2773333002 > Cr-Commit-Position: refs/heads/master@{#459696} > Committed: https://chromium.googlesource.com/chromium/src/+/6625b2f764ae4efb0637215660500ba721b8a43d TBR=wfh@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=661774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1733 lines, -0 lines) Patch
A sandbox/win/tools/finder/finder.h View 1 chunk +144 lines, -0 lines 0 comments Download
A sandbox/win/tools/finder/finder.cc View 1 chunk +61 lines, -0 lines 0 comments Download
A sandbox/win/tools/finder/finder.vcproj View 1 chunk +201 lines, -0 lines 0 comments Download
A sandbox/win/tools/finder/finder_fs.cc View 1 chunk +117 lines, -0 lines 0 comments Download
A sandbox/win/tools/finder/finder_kernel.cc View 1 chunk +248 lines, -0 lines 0 comments Download
A sandbox/win/tools/finder/finder_registry.cc View 1 chunk +93 lines, -0 lines 0 comments Download
A sandbox/win/tools/finder/main.cc View 1 chunk +147 lines, -0 lines 0 comments Download
A sandbox/win/tools/finder/ntundoc.h View 1 chunk +275 lines, -0 lines 0 comments Download
A sandbox/win/tools/launcher/launcher.cc View 1 chunk +270 lines, -0 lines 0 comments Download
A sandbox/win/tools/launcher/launcher.vcproj View 1 chunk +177 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Created Revert of Remove sandbox/win/tools.
3 years, 9 months ago (2017-03-27 03:40:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773423002/1
3 years, 9 months ago (2017-03-27 03:40:31 UTC) #3
commit-bot: I haz the power
Failed to apply patch for sandbox/win/tools/finder/finder.cc: While running git apply --index -p1; error: sandbox/win/tools/finder/finder.cc: already ...
3 years, 9 months ago (2017-03-27 03:41:51 UTC) #5
tkent
3 years, 9 months ago (2017-03-27 03:44:44 UTC) #6
It was already reverted. Closing.

Powered by Google App Engine
This is Rietveld 408576698