Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2773403003: Removed device_supports_touch. (Closed)

Created:
3 years, 9 months ago by mustaq
Modified:
3 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed device_supports_touch. Most of the uses of device_supports_touch have been removed already, and device_supports_mouse is already gone. This CL nukes this field w/o any change in existing behavior. BUG=441813 Review-Url: https://codereview.chromium.org/2773403003 Cr-Commit-Position: refs/heads/master@{#460450} Committed: https://chromium.googlesource.com/chromium/src/+/fbb14599c4d794c4fc3ab13e243ef7c7c0416fa7

Patch Set 1 #

Patch Set 2 : Preserved old touch-flag behavior. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 26 (17 generated)
mustaq
ptal
3 years, 8 months ago (2017-03-28 15:11:59 UTC) #5
dtapuska
On 2017/03/28 15:11:59, mustaq wrote: > ptal lgtm
3 years, 8 months ago (2017-03-28 15:14:59 UTC) #7
mustaq
Need approval: - rbyers@chromium.org: third_party/Webkit/ - avi@chromium.org: content/
3 years, 8 months ago (2017-03-28 15:42:08 UTC) #9
Avi (use Gerrit)
LGTM
3 years, 8 months ago (2017-03-28 15:43:54 UTC) #10
Rick Byers
WebKit LGTM
3 years, 8 months ago (2017-03-29 15:33:11 UTC) #17
mustaq
kenrb@chromium.org: Please review changes in common_param_traits_macros.h
3 years, 8 months ago (2017-03-29 15:36:31 UTC) #19
kenrb
ipc lgtm
3 years, 8 months ago (2017-03-29 15:41:41 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773403003/20001
3 years, 8 months ago (2017-03-29 15:42:40 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 17:57:29 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fbb14599c4d794c4fc3ab13e243e...

Powered by Google App Engine
This is Rietveld 408576698