Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1879)

Unified Diff: chrome/browser/installable/installable_manager.h

Issue 2773353002: Make minimum PWA icon size the same accross all device densities
Patch Set: Merge branch 'master' into min_size Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/installable/installable_manager.h
diff --git a/chrome/browser/installable/installable_manager.h b/chrome/browser/installable/installable_manager.h
index 5d56abd0e35b2c22e0a9c43bcf3e4b70d394e9b1..83ae4e264bf0a33ed8f7336dbce6f1b14cc0f18d 100644
--- a/chrome/browser/installable/installable_manager.h
+++ b/chrome/browser/installable/installable_manager.h
@@ -7,7 +7,6 @@
#include <map>
#include <memory>
-#include <tuple>
#include <utility>
#include <vector>
@@ -31,18 +30,10 @@ struct InstallableParams {
// |fetch_valid_primary_icon| is true.
int ideal_primary_icon_size_in_px = -1;
- // The minimum primary icon size to fetch. Used only if
- // |fetch_valid_primary_icon| is true.
- int minimum_primary_icon_size_in_px = -1;
-
// The ideal badge icon size to fetch. Used only if
// |fetch_valid_badge_icon| is true.
int ideal_badge_icon_size_in_px = -1;
- // The minimum badge icon size to fetch. Used only if
- // |fetch_valid_badge_icon| is true.
- int minimum_badge_icon_size_in_px = -1;
-
// Check whether the site is installable. That is, it has a manifest valid for
// a web app and a service worker controlling the manifest start URL and the
// current URL.
@@ -135,7 +126,7 @@ class InstallableManager
FRIEND_TEST_ALL_PREFIXES(InstallableManagerBrowserTest, CheckWebapp);
using Task = std::pair<InstallableParams, InstallableCallback>;
- using IconParams = std::tuple<int, int, content::Manifest::Icon::IconPurpose>;
+ using IconParams = std::pair<int, content::Manifest::Icon::IconPurpose>;
struct ManifestProperty;
struct InstallableProperty;

Powered by Google App Engine
This is Rietveld 408576698