Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 2773353002: Make minimum PWA icon size the same accross all device densities
Patch Set: Merge branch 'master' into min_size Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index 726f25f9b08860ac1725368595806c6207059fe0..fe08583e7c0d8bc1d1795e00238d97294561bdd3 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -184,10 +184,6 @@ int AppBannerManager::GetIdealPrimaryIconSizeInPx() {
return InstallableManager::GetMinimumIconSizeInPx();
}
-int AppBannerManager::GetMinimumPrimaryIconSizeInPx() {
- return InstallableManager::GetMinimumIconSizeInPx();
-}
-
base::WeakPtr<AppBannerManager> AppBannerManager::GetWeakPtr() {
return weak_factory_.GetWeakPtr();
}
@@ -228,7 +224,6 @@ void AppBannerManager::OnDidGetManifest(const InstallableData& data) {
InstallableParams AppBannerManager::ParamsToPerformInstallableCheck() {
InstallableParams params;
params.ideal_primary_icon_size_in_px = GetIdealPrimaryIconSizeInPx();
- params.minimum_primary_icon_size_in_px = GetMinimumPrimaryIconSizeInPx();
params.check_installable = true;
params.fetch_valid_primary_icon = true;

Powered by Google App Engine
This is Rietveld 408576698