Make GrGLConfigConversionEffect work for Imagination and some other GPUs.

src/gpu/effects/GrConfigConversionEffect.cpp

Index: src/gpu/effects/GrConfigConversionEffect.cpp
diff --git a/src/gpu/effects/GrConfigConversionEffect.cpp b/src/gpu/effects/GrConfigConversionEffect.cpp
index f33ad239c518b1de5f98ccec29e02394670a9dd0..4b5b99fd86b7e52d97064f33860d73d17cda05e3 100644
--- a/src/gpu/effects/GrConfigConversionEffect.cpp
+++ b/src/gpu/effects/GrConfigConversionEffect.cpp
@@ -29,6 +29,8 @@ public:
                           const char* inputColor,
                           const TransformedCoordsArray& coords,
                           const TextureSamplerArray& samplers) SK_OVERRIDE {
+        const char* outputColorH = "outputColorH";
+        builder->fsCodeAppendf("\thighp vec4 %s;\n", outputColorH);

[bsalomon, 2014/07/08 13:10:15]

It looks like we're still always declaring this variable even if it isn't used.
Can you move this into the four cases below that need it?

[changjun.yang, 2014/07/09 03:02:09]

Done. And looks we still need the outputColorH though.

         builder->fsCodeAppendf("\t\t%s = ", outputColor);
         builder->fsAppendTextureLookup(samplers[0], coords[0].c_str(), coords[0].type());
         builder->fsCodeAppend(";\n");
@@ -60,6 +62,32 @@ public:
                     builder->fsCodeAppendf("\t\t%s = %s.a <= 0.0 ? vec4(0,0,0,0) : vec4(floor(%s.%s / %s.a * 255.0) / 255.0, %s.a);\n",
                         outputColor, outputColor, outputColor, swiz, outputColor, outputColor);
                     break;
+                case GrConfigConversionEffect::kMulByAlpha_RoundUp_HIGHP_PMConversion:
+                    builder->fsCodeAppendf("\t\t%s = %s;\n", outputColorH, outputColor);
+                    builder->fsCodeAppendf(
+                        "\t\t%s = vec4(ceil(%s.%s * %s.a * 255.0) / 255.0, %s.a);\n",
+                        outputColorH, outputColorH, swiz, outputColorH, outputColorH);
+                    builder->fsCodeAppendf("\t\t%s = %s;\n", outputColor, outputColorH);
+                    break;
+                case GrConfigConversionEffect::kMulByAlpha_RoundDown_HIGHP_PMConversion:
+                    builder->fsCodeAppendf("\t\t%s = %s;\n", outputColorH, outputColor);
+                    builder->fsCodeAppendf(
+                        "\t\t%s = vec4(floor(%s.%s * %s.a * 255.0) / 255.0, %s.a);\n",
+                        outputColorH, outputColorH, swiz, outputColorH, outputColorH);
+                    builder->fsCodeAppendf("\t\t%s = %s;\n", outputColor, outputColorH);
+                    break;
+                case GrConfigConversionEffect::kDivByAlpha_RoundUp_HIGHP_PMConversion:
+                    builder->fsCodeAppendf("\t\t%s = %s;\n", outputColorH, outputColor);
+                    builder->fsCodeAppendf("\t\t%s = %s.a <= 0.0 ? vec4(0,0,0,0) : vec4(ceil(%s.%s / %s.a * 255.0) / 255.0, %s.a);\n",
+                        outputColorH, outputColorH, outputColorH, swiz, outputColorH, outputColorH);
+                    builder->fsCodeAppendf("\t\t%s = %s;\n", outputColor, outputColorH);
+                    break;
+                case GrConfigConversionEffect::kDivByAlpha_RoundDown_HIGHP_PMConversion:
+                    builder->fsCodeAppendf("\t\t%s = %s;\n", outputColorH, outputColor);
+                    builder->fsCodeAppendf("\t\t%s = %s.a <= 0.0 ? vec4(0,0,0,0) : vec4(floor(%s.%s / %s.a * 255.0) / 255.0, %s.a);\n",
+                        outputColorH, outputColorH, outputColorH, swiz, outputColorH, outputColorH);
+                    builder->fsCodeAppendf("\t\t%s = %s;\n", outputColor, outputColorH);
+                    break;
                 default:
                     SkFAIL("Unknown conversion op.");
                     break;
@@ -184,6 +212,8 @@ void GrConfigConversionEffect::TestForPreservingPMConversions(GrContext* context
     static const PMConversion kConversionRules[][2] = {
         {kDivByAlpha_RoundDown_PMConversion, kMulByAlpha_RoundUp_PMConversion},
         {kDivByAlpha_RoundUp_PMConversion, kMulByAlpha_RoundDown_PMConversion},
+        {kDivByAlpha_RoundDown_HIGHP_PMConversion, kMulByAlpha_RoundUp_HIGHP_PMConversion},
+        {kDivByAlpha_RoundUp_HIGHP_PMConversion, kMulByAlpha_RoundDown_HIGHP_PMConversion},
     };
 
     GrContext::AutoWideOpenIdentityDraw awoid(context, NULL);