Make GrGLConfigConversionEffect work for Imagination and some other GPUs.

src/gpu/effects/GrConfigConversionEffect.cpp

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "GrConfigConversionEffect.h"
 #include "GrContext.h"
 #include "GrTBackendEffectFactory.h"
@@ skipping 11 matching lines @@
         fPMConversion = effect.pmConversion();
     }
 
     virtual void emitCode(GrGLShaderBuilder* builder,
                           const GrDrawEffect&,
                           EffectKey key,
                           const char* outputColor,
                           const char* inputColor,
                           const TransformedCoordsArray& coords,
                           const TextureSamplerArray& samplers) SK_OVERRIDE {
+        const char* outputColorH = "outputColorH";
+        builder->fsCodeAppendf("\thighp vec4 %s;\n", outputColorH);

[bsalomon, 2014/07/08 13:10:15]

It looks like we're still always declaring this variable even if it isn't used.
Can you move this into the four cases below that need it?

[changjun.yang, 2014/07/09 03:02:09]

Done. And looks we still need the outputColorH though.

         builder->fsCodeAppendf("\t\t%s = ", outputColor);
         builder->fsAppendTextureLookup(samplers[0], coords[0].c_str(), coords[0].type());
         builder->fsCodeAppend(";\n");
         if (GrConfigConversionEffect::kNone_PMConversion == fPMConversion) {
             SkASSERT(fSwapRedAndBlue);
             builder->fsCodeAppendf("\t%s = %s.bgra;\n", outputColor, outputColor);
         } else {
             const char* swiz = fSwapRedAndBlue ? "bgr" : "rgb";
             switch (fPMConversion) {
                 case GrConfigConversionEffect::kMulByAlpha_RoundUp_PMConversion:
@@ skipping 11 matching lines @@
                         outputColor, outputColor, swiz, outputColor, outputColor);
                     break;
                 case GrConfigConversionEffect::kDivByAlpha_RoundUp_PMConversion:
                     builder->fsCodeAppendf("\t\t%s = %s.a <= 0.0 ? vec4(0,0,0,0) : vec4(ceil(%s.%s / %s.a * 255.0) / 255.0, %s.a);\n",
                         outputColor, outputColor, outputColor, swiz, outputColor, outputColor);
                     break;
                 case GrConfigConversionEffect::kDivByAlpha_RoundDown_PMConversion:
                     builder->fsCodeAppendf("\t\t%s = %s.a <= 0.0 ? vec4(0,0,0,0) : vec4(floor(%s.%s / %s.a * 255.0) / 255.0, %s.a);\n",
                         outputColor, outputColor, outputColor, swiz, outputColor, outputColor);
                     break;
+                case GrConfigConversionEffect::kMulByAlpha_RoundUp_HIGHP_PMConversion:
+                    builder->fsCodeAppendf("\t\t%s = %s;\n", outputColorH, outputColor);
+                    builder->fsCodeAppendf(
+                        "\t\t%s = vec4(ceil(%s.%s * %s.a * 255.0) / 255.0, %s.a);\n",
+                        outputColorH, outputColorH, swiz, outputColorH, outputColorH);
+                    builder->fsCodeAppendf("\t\t%s = %s;\n", outputColor, outputColorH);
+                    break;
+                case GrConfigConversionEffect::kMulByAlpha_RoundDown_HIGHP_PMConversion:
+                    builder->fsCodeAppendf("\t\t%s = %s;\n", outputColorH, outputColor);
+                    builder->fsCodeAppendf(
+                        "\t\t%s = vec4(floor(%s.%s * %s.a * 255.0) / 255.0, %s.a);\n",
+                        outputColorH, outputColorH, swiz, outputColorH, outputColorH);
+                    builder->fsCodeAppendf("\t\t%s = %s;\n", outputColor, outputColorH);
+                    break;
+                case GrConfigConversionEffect::kDivByAlpha_RoundUp_HIGHP_PMConversion:
+                    builder->fsCodeAppendf("\t\t%s = %s;\n", outputColorH, outputColor);
+                    builder->fsCodeAppendf("\t\t%s = %s.a <= 0.0 ? vec4(0,0,0,0) : vec4(ceil(%s.%s / %s.a * 255.0) / 255.0, %s.a);\n",
+                        outputColorH, outputColorH, outputColorH, swiz, outputColorH, outputColorH);
+                    builder->fsCodeAppendf("\t\t%s = %s;\n", outputColor, outputColorH);
+                    break;
+                case GrConfigConversionEffect::kDivByAlpha_RoundDown_HIGHP_PMConversion:
+                    builder->fsCodeAppendf("\t\t%s = %s;\n", outputColorH, outputColor);
+                    builder->fsCodeAppendf("\t\t%s = %s.a <= 0.0 ? vec4(0,0,0,0) : vec4(floor(%s.%s / %s.a * 255.0) / 255.0, %s.a);\n",
+                        outputColorH, outputColorH, outputColorH, swiz, outputColorH, outputColorH);
+                    builder->fsCodeAppendf("\t\t%s = %s;\n", outputColor, outputColorH);
+                    break;
                 default:
                     SkFAIL("Unknown conversion op.");
                     break;
             }
         }
         SkString modulate;
         GrGLSLMulVarBy4f(&modulate, 2, outputColor, inputColor);
         builder->fsCodeAppend(modulate.c_str());
     }
 
@@ skipping 104 matching lines @@
     }
     desc.fFlags = kNone_GrTextureFlags;
     SkAutoTUnref<GrTexture> dataTex(context->createUncachedTexture(desc, data, 0));
     if (!dataTex.get()) {
         return;
     }
 
     static const PMConversion kConversionRules[][2] = {
         {kDivByAlpha_RoundDown_PMConversion, kMulByAlpha_RoundUp_PMConversion},
         {kDivByAlpha_RoundUp_PMConversion, kMulByAlpha_RoundDown_PMConversion},
+        {kDivByAlpha_RoundDown_HIGHP_PMConversion, kMulByAlpha_RoundUp_HIGHP_PMConversion},
+        {kDivByAlpha_RoundUp_HIGHP_PMConversion, kMulByAlpha_RoundDown_HIGHP_PMConversion},
     };
 
     GrContext::AutoWideOpenIdentityDraw awoid(context, NULL);
 
     bool failed = true;
 
     for (size_t i = 0; i < SK_ARRAY_COUNT(kConversionRules) && failed; ++i) {
         *pmToUPMRule = kConversionRules[i][0];
         *upmToPMRule = kConversionRules[i][1];
 
@@ skipping 71 matching lines @@
             // The PM conversions assume colors are 0..255
             return NULL;
         }
         AutoEffectUnref effect(SkNEW_ARGS(GrConfigConversionEffect, (texture,
                                                                      swapRedAndBlue,
                                                                      pmConversion,
                                                                      matrix)));
         return CreateEffectRef(effect);
     }
 }