Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(131)

Issue 2773143002: [inspector] finally removed *ExecuteScript from inspector (Closed)

Created:
2 years, 6 months ago by kozy
Modified:
2 years, 6 months ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] finally removed *ExecuteScript from inspector We don't need hints from embedder any more. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2773143002 Cr-Commit-Position: refs/heads/master@{#44158} Committed: https://chromium.googlesource.com/v8/v8/+/43791ce02c8bb566915c948fd6f48d3fe8bb99fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M include/v8-inspector.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/inspector/v8-inspector-impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/inspector/v8-inspector-impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
kozy
Dmitry, I need your owner lgtm for v8-inspector.h.
2 years, 6 months ago (2017-03-24 16:20:39 UTC) #3
dgozman
lgtm
2 years, 6 months ago (2017-03-27 16:33:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773143002/1
2 years, 6 months ago (2017-03-27 18:18:44 UTC) #6
commit-bot: I haz the power
2 years, 6 months ago (2017-03-27 19:26:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/43791ce02c8bb566915c948fd6f48d3fe8b...

Powered by Google App Engine
This is Rietveld 408576698