Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2773123002: Control FreeType linkage globally in //build/config/freetype (Closed)

Created:
3 years, 9 months ago by drott
Modified:
3 years, 9 months ago
CC:
chromium-reviews, Lei Zhang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Control FreeType linkage globally in //build/config/freetype Preparation for linking FreeType on Windows. BUG=700926 Review-Url: https://codereview.chromium.org/2773123002 Cr-Commit-Position: refs/heads/master@{#459471} Committed: https://chromium.googlesource.com/chromium/src/+/53207ce64fc1d03d0fce3f8596a4a3ba1f917543

Patch Set 1 #

Patch Set 2 : Fix Fontconfig build on cast shell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
A build/config/freetype/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
M build/linux/BUILD.gn View 1 chunk +1 line, -11 lines 0 comments Download
M skia/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/fontconfig/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (14 generated)
drott
3 years, 9 months ago (2017-03-24 14:30:21 UTC) #3
drott
Lei, fyi, //build/config/freetype could be the target that we use as a unified source of ...
3 years, 9 months ago (2017-03-24 14:32:09 UTC) #6
Nico
lgtm
3 years, 9 months ago (2017-03-24 15:01:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773123002/20001
3 years, 9 months ago (2017-03-24 17:43:53 UTC) #15
Lei Zhang
sgtm
3 years, 9 months ago (2017-03-24 17:45:48 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 17:51:58 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/53207ce64fc1d03d0fce3f8596a4...

Powered by Google App Engine
This is Rietveld 408576698