Chromium Code Reviews

Issue 2773093002: Revert "[heap] Make SlotSet allocation thread-safe and refactor code." (Closed)

Created:
3 years, 9 months ago by Hannes Payer (out of office)
Modified:
3 years, 9 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[heap] Make SlotSet allocation thread-safe and refactor code." This reverts commit 00d3098d70e76ba71afcec9935d6d37f0b49f53a. BUG=chromium:694255, v8:6138 Review-Url: https://codereview.chromium.org/2773093002 Cr-Commit-Position: refs/heads/master@{#44100} Committed: https://chromium.googlesource.com/v8/v8/+/4693a4337a5fdff6645786518e560cd476c765d8

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+162 lines, -136 lines)
M src/heap/mark-compact.cc View 9 chunks +26 lines, -28 lines 0 comments
M src/heap/remembered-set.h View 11 chunks +64 lines, -19 lines 0 comments
M src/heap/spaces.h View 4 chunks +29 lines, -34 lines 0 comments
M src/heap/spaces.cc View 3 chunks +39 lines, -51 lines 0 comments
M src/heap/spaces-inl.h View 1 chunk +4 lines, -4 lines 0 comments

Messages

Total messages: 10 (7 generated)
ulan
lgtm
3 years, 9 months ago (2017-03-24 12:11:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773093002/1
3 years, 9 months ago (2017-03-24 12:17:08 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 12:36:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4693a4337a5fdff6645786518e560cd476c...

Powered by Google App Engine