[wasm] Override mechanism for wasm js APIs

[wasm] Override mechanism for wasm js APIs

V8 side mechanism for overriding the wasm js APIs.

We will use these to:
- implement the Chrome-side constraints on module size, and throw with more
actionable error messages, while preserving layering.
The old mechansms will be deleted once we update the Chrome side with
this new mechanism.

- implement Chrome-side .compile and .instantiate overrides accepting
Response objects.

We may want to evolve this mechanism into something more general, not
requiring V8 preparation, by replacing the v8-definition with embedder
provided definitions. We're currently exploring if we can expand
"Extras", for instance.

BUG=

Review-Url: https://codereview.chromium.org/2773063002
Cr-Commit-Position: refs/heads/master@{#44119}
Committed: https://chromium.googlesource.com/v8/v8/+/5fdb5a148e7759b89d09ca5eac5a24af63bdd125

[Mircea Trofin, 2017-03-24 05:13:59]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 05:14:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mircea Trofin, 2017-03-24 05:15:05]

Description was changed from

==========
[wasm] Override mechanism for wasm js APIs

V8 side mechanism for overriding the wasm js APIs.

We will use these to:
- implement the Chrome-side constraints on module size, and throw with more
actionable error messages, while preserving layering.
The old mechansms will be deleted once we update the Chrome side with
this new mechanism.

- implement Chrome-side .compile and .instantiate overrides accepting
Response objects.

We may want to evolve this mechanism into something more general, not
requiring V8 preparation, by replacing the v8-definition with embedder
provided definitions. We're currently exploring if we can expand
"Extras", for instance.

BUG=
==========

to

==========
[wasm] Override mechanism for wasm js APIs

V8 side mechanism for overriding the wasm js APIs.

We will use these to:
- implement the Chrome-side constraints on module size, and throw with more
actionable error messages, while preserving layering.
The old mechansms will be deleted once we update the Chrome side with
this new mechanism.

- implement Chrome-side .compile and .instantiate overrides accepting
Response objects.

We may want to evolve this mechanism into something more general, not
requiring V8 preparation, by replacing the v8-definition with embedder
provided definitions. We're currently exploring if we can expand
"Extras", for instance.

BUG=
==========

[Mircea Trofin, 2017-03-24 05:15:05]

mtrofin@chromium.org changed reviewers:
+ bradnelson@chromium.org

[commit-bot: I haz the power, 2017-03-24 05:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 05:37:44]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[bradnelson, 2017-03-24 17:45:24]

lgtm w/ naming questions

https://codereview.chromium.org/2773063002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2773063002/diff/1/include/v8.h#newcode6011
include/v8.h:6011: typedef bool (*ExtensionCallback)(const
FunctionCallbackInfo<Value>&);
This is pretty generic name, is the idea we'd eventually use this for more than
wasm?

https://codereview.chromium.org/2773063002/diff/1/src/runtime/runtime-test.cc
File src/runtime/runtime-test.cc (right):

https://codereview.chromium.org/2773063002/diff/1/src/runtime/runtime-test.cc...
src/runtime/runtime-test.cc:92: ThrowRangeException(args.GetIsolate(), "Sync
compile not allowed");
Did we want to mention wasm in the error messages?

[Mircea Trofin, 2017-03-24 17:57:56]

https://codereview.chromium.org/2773063002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2773063002/diff/1/include/v8.h#newcode6011
include/v8.h:6011: typedef bool (*ExtensionCallback)(const
FunctionCallbackInfo<Value>&);
On 2017/03/24 17:45:24, bradnelson wrote:
> This is pretty generic name, is the idea we'd eventually use this for more
than
> wasm?

The hope is we'd delete this in favor of a "Extras" (JS) mechanism, but for now,
it's generic enough - all JS APIs receive that type of parameter.

https://codereview.chromium.org/2773063002/diff/1/src/runtime/runtime-test.cc
File src/runtime/runtime-test.cc (right):

https://codereview.chromium.org/2773063002/diff/1/src/runtime/runtime-test.cc...
src/runtime/runtime-test.cc:92: ThrowRangeException(args.GetIsolate(), "Sync
compile not allowed");
On 2017/03/24 17:45:24, bradnelson wrote:
> Did we want to mention wasm in the error messages?

Why bother, it's a test :)

[Mircea Trofin, 2017-03-24 17:58:02]

The CQ bit was checked by mtrofin@chromium.org

[commit-bot: I haz the power, 2017-03-24 17:58:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 18:26:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490378282302430, "parent_rev":
"4482bc2e76d7c68259406021f5fa2d2167a0e70d", "commit_rev":
"5fdb5a148e7759b89d09ca5eac5a24af63bdd125"}

[commit-bot: I haz the power, 2017-03-24 18:26:13]

Description was changed from

==========
[wasm] Override mechanism for wasm js APIs

V8 side mechanism for overriding the wasm js APIs.

We will use these to:
- implement the Chrome-side constraints on module size, and throw with more
actionable error messages, while preserving layering.
The old mechansms will be deleted once we update the Chrome side with
this new mechanism.

- implement Chrome-side .compile and .instantiate overrides accepting
Response objects.

We may want to evolve this mechanism into something more general, not
requiring V8 preparation, by replacing the v8-definition with embedder
provided definitions. We're currently exploring if we can expand
"Extras", for instance.

BUG=
==========

to

==========
[wasm] Override mechanism for wasm js APIs

V8 side mechanism for overriding the wasm js APIs.

We will use these to:
- implement the Chrome-side constraints on module size, and throw with more
actionable error messages, while preserving layering.
The old mechansms will be deleted once we update the Chrome side with
this new mechanism.

- implement Chrome-side .compile and .instantiate overrides accepting
Response objects.

We may want to evolve this mechanism into something more general, not
requiring V8 preparation, by replacing the v8-definition with embedder
provided definitions. We're currently exploring if we can expand
"Extras", for instance.

BUG=

Review-Url: https://codereview.chromium.org/2773063002
Cr-Commit-Position: refs/heads/master@{#44119}
Committed:
https://chromium.googlesource.com/v8/v8/+/5fdb5a148e7759b89d09ca5eac5a24af63b...
==========

[commit-bot: I haz the power, 2017-03-24 18:26:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5fdb5a148e7759b89d09ca5eac5a24af63b...