Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2773043005: GN: Trim newlines in markdown help blocks (Closed)

Created:
3 years, 8 months ago by timn
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Trim newlines in markdown help blocks In markdown mode (--markdown) GN puts the actual help text into fenced blocks. Newlines at the beginning or end of such a block are not stripped and appear in the generated HTML output, taking up vertical space. This change ensures that newlines at the start and end are removed. BUG= Review-Url: https://codereview.chromium.org/2773043005 Cr-Commit-Position: refs/heads/master@{#460024} Committed: https://chromium.googlesource.com/chromium/src/+/823f2a25b3be32ce6920072ec2b9c2d9f06ec377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M tools/gn/command_help.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/standard_out.cc View 3 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
timn
Here's a screenshot illustrating the change: https://drive.google.com/open?id=0B7IsT9R2REy-S19sMmpsSHFvX2s The normal text output remains unchanged.
3 years, 8 months ago (2017-03-25 17:53:59 UTC) #2
brettw
lgtm
3 years, 8 months ago (2017-03-27 16:55:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773043005/1
3 years, 8 months ago (2017-03-28 06:01:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/823f2a25b3be32ce6920072ec2b9c2d9f06ec377
3 years, 8 months ago (2017-03-28 06:07:21 UTC) #12
Dirk Pranke
3 years, 8 months ago (2017-04-01 01:05:02 UTC) #13
Message was sent while issue was closed.
lgtm also, thanks!

Powered by Google App Engine
This is Rietveld 408576698