make --enable-hdr imply --enable-features=video-color-management

make --enable-hdr imply --enable-features=video-color-management

EOM

BUG=682416
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2773043004
Cr-Commit-Position: refs/heads/master@{#459929}
Committed: https://chromium.googlesource.com/chromium/src/+/b1b0096d4e30422d3084c0e238684e45ff61083c

[hubbe, 2017-03-25 00:01:23]

Description was changed from

==========
make --enable-hdr imply --enable-features=video-color-management

EOM

BUG=682416
==========

to

==========
make --enable-hdr imply --enable-features=video-color-management

EOM

BUG=682416
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[hubbe, 2017-03-25 00:01:29]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 00:02:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hubbe, 2017-03-25 00:02:18]

hubbe@chromium.org changed reviewers:
+ ccameron@chromium.org

[ccameron, 2017-03-25 00:19:13]

https://codereview.chromium.org/2773043004/diff/1/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2773043004/diff/1/cc/output/gl_renderer.cc#ne...
cc/output/gl_renderer.cc:2068: switches::kEnableHDR)) {
Settings are sent to cc/ via the cc::RendererSettings structure instead of the
command line.

Couple of options here:
A: you can create a new cc::RendererSettings (following the behavior of
cc::RendererSettings::enable_color_correct_rendering)
B: you can just link off of
cc::RendererSettings::enable_color_correct_rendering, cause it'll be set by
kEnableHDR

I'd suggest B, which would end up being just:
  if (!base::FeatureList::IsEnabled(media::kVideoColorManagement) &&
      !settings_->enable_color_correct_rendering) {

[commit-bot: I haz the power, 2017-03-25 01:24:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 01:24:57]

Dry run: This issue passed the CQ dry run.

[hubbe, 2017-03-27 21:34:35]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[hubbe, 2017-03-27 21:35:17]

PTAL

https://codereview.chromium.org/2773043004/diff/1/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2773043004/diff/1/cc/output/gl_renderer.cc#ne...
cc/output/gl_renderer.cc:2068: switches::kEnableHDR)) {
On 2017/03/25 00:19:13, ccameron wrote:
> Settings are sent to cc/ via the cc::RendererSettings structure instead of the
> command line.
> 
> Couple of options here:
> A: you can create a new cc::RendererSettings (following the behavior of
> cc::RendererSettings::enable_color_correct_rendering)
> B: you can just link off of
> cc::RendererSettings::enable_color_correct_rendering, cause it'll be set by
> kEnableHDR
> 
> I'd suggest B, which would end up being just:
>   if (!base::FeatureList::IsEnabled(media::kVideoColorManagement) &&
>       !settings_->enable_color_correct_rendering) {

option B sounds good.

[commit-bot: I haz the power, 2017-03-27 21:36:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-03-27 21:40:09]

lgtm

[hubbe, 2017-03-27 21:41:21]

The CQ bit was unchecked by hubbe@chromium.org

[hubbe, 2017-03-27 21:41:23]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2017-03-27 21:42:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 23:17:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490650883653890,
"parent_rev": "69875b5a5f926383fe0e2d476bf6c42c30b8b741", "commit_rev":
"b1b0096d4e30422d3084c0e238684e45ff61083c"}

[commit-bot: I haz the power, 2017-03-27 23:19:21]

Description was changed from

==========
make --enable-hdr imply --enable-features=video-color-management

EOM

BUG=682416
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
make --enable-hdr imply --enable-features=video-color-management

EOM

BUG=682416
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2773043004
Cr-Commit-Position: refs/heads/master@{#459929}
Committed:
https://chromium.googlesource.com/chromium/src/+/b1b0096d4e30422d3084c0e23868...
==========

[commit-bot: I haz the power, 2017-03-27 23:19:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b1b0096d4e30422d3084c0e23868...