content/shell/test_runner/web_view_test_client.h - Issue 2773003002: Make the WebWidgetClient parameter a ref so it's not legal to pass a nullptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/test_runner/web_view_test_client.h

Issue 2773003002: Make the WebWidgetClient parameter a ref so it's not legal to pass a nullptr. (Closed)

Patch Set: WebViewClient dtor now overrides the virtual dtor in WebWidgetClient. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/test_runner/web_view_test_client.h

diff --git a/content/shell/test_runner/web_view_test_client.h b/content/shell/test_runner/web_view_test_client.h

index a76defa739c40910cebc755add6da4e8822d38b1..75a78ac70cd79aa38441d923d03d4e52b2309a10 100644

--- a/content/shell/test_runner/web_view_test_client.h

+++ b/content/shell/test_runner/web_view_test_client.h

@@ -27,7 +27,7 @@ class WebViewTestClient : public blink::WebViewClient {

// Caller has to ensure |web_view_test_proxy_base| lives longer than |this|.

WebViewTestClient(WebViewTestProxyBase* web_view_test_proxy_base);

- virtual ~WebViewTestClient();

+ ~WebViewTestClient() override;

// WebViewClient overrides needed by WebViewTestProxy.

void showValidationMessage(const blink::WebRect& anchor_in_root_view,