Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: components/printing/renderer/print_web_view_helper.cc

Issue 2773003002: Make the WebWidgetClient parameter a ref so it's not legal to pass a nullptr. (Closed)
Patch Set: WebViewClient dtor now overrides the virtual dtor in WebWidgetClient. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/shell/test_runner/web_view_test_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/printing/renderer/print_web_view_helper.cc
diff --git a/components/printing/renderer/print_web_view_helper.cc b/components/printing/renderer/print_web_view_helper.cc
index 4900973ebb215fe0f93106bf2033d670dc188f47..2639579cdde4e3e4e5e9af793b18f138d551fc26 100644
--- a/components/printing/renderer/print_web_view_helper.cc
+++ b/components/printing/renderer/print_web_view_helper.cc
@@ -589,7 +589,8 @@ void PrintWebViewHelper::PrintHeaderAndFooter(
blink::WebLocalFrame* frame = blink::WebLocalFrame::create(
blink::WebTreeScopeType::Document, &frame_client, nullptr, nullptr);
web_view->setMainFrame(frame);
- blink::WebFrameWidget::create(nullptr, web_view, frame);
+ blink::WebWidgetClient web_widget_client;
+ blink::WebFrameWidget::create(&web_widget_client, web_view, frame);
base::Value html(ResourceBundle::GetSharedInstance().GetLocalizedString(
IDR_PRINT_PREVIEW_PAGE));
« no previous file with comments | « no previous file | content/shell/test_runner/web_view_test_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698