Make sure channel-associated interface pointers are always safe to call.

Make sure channel-associated interface pointers are always safe to call.

Previously, GetRemoteAssociatedInterface() could drop the associated request if
the channel was not connected. It would lead to crash when the corresponding
associated interface pointer is used to make calls.

This CL makes the request associated with a dedicated, disconnected message pipe
instead of dropping it. That way it is safe to make calls with the interface
pointer.

BUG=704504
Review-Url: https://codereview.chromium.org/2772983002
Cr-Commit-Position: refs/heads/master@{#459642}
Committed: https://chromium.googlesource.com/chromium/src/+/34dcca73d8f6406f791804d4ee90a60191878573

[yzshen1, 2017-03-23 23:49:49]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 23:50:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-03-23 23:50:42]

yzshen@chromium.org changed reviewers:
+ rockot@chromium.org

[yzshen1, 2017-03-23 23:50:43]

Hi, Ken.

Please take a look. Thanks!

[commit-bot: I haz the power, 2017-03-24 00:59:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 00:59:11]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2017-03-24 19:20:03]

lgtm

https://codereview.chromium.org/2772983002/diff/1/ipc/ipc_channel_mojo.cc
File ipc/ipc_channel_mojo.cc (right):

https://codereview.chromium.org/2772983002/diff/1/ipc/ipc_channel_mojo.cc#new...
ipc/ipc_channel_mojo.cc:485: mojo::GetIsolatedInterface(std::move(handle));
nit: I might consider documenting here why we do this and why it's OK.

[yzshen1, 2017-03-25 07:18:15]

https://codereview.chromium.org/2772983002/diff/1/ipc/ipc_channel_mojo.cc
File ipc/ipc_channel_mojo.cc (right):

https://codereview.chromium.org/2772983002/diff/1/ipc/ipc_channel_mojo.cc#new...
ipc/ipc_channel_mojo.cc:485: mojo::GetIsolatedInterface(std::move(handle));
On 2017/03/24 19:20:03, Ken Rockot wrote:
> nit: I might consider documenting here why we do this and why it's OK.

Done.

[yzshen1, 2017-03-25 07:18:19]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2017-03-25 07:18:19]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2772983002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2017-03-25 07:18:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 08:27:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490426299451540,
"parent_rev": "628771d2f70705a9aba44a5f994dafdac9fd61ea", "commit_rev":
"34dcca73d8f6406f791804d4ee90a60191878573"}

[commit-bot: I haz the power, 2017-03-25 08:28:47]

Description was changed from

==========
Make sure channel-associated interface pointers are always safe to call.

Previously, GetRemoteAssociatedInterface() could drop the associated request if
the channel was not connected. It would lead to crash when the corresponding
associated interface pointer is used to make calls.

This CL makes the request associated with a dedicated, disconnected message pipe
instead of dropping it. That way it is safe to make calls with the interface
pointer.

BUG=704504
==========

to

==========
Make sure channel-associated interface pointers are always safe to call.

Previously, GetRemoteAssociatedInterface() could drop the associated request if
the channel was not connected. It would lead to crash when the corresponding
associated interface pointer is used to make calls.

This CL makes the request associated with a dedicated, disconnected message pipe
instead of dropping it. That way it is safe to make calls with the interface
pointer.

BUG=704504

Review-Url: https://codereview.chromium.org/2772983002
Cr-Commit-Position: refs/heads/master@{#459642}
Committed:
https://chromium.googlesource.com/chromium/src/+/34dcca73d8f6406f791804d4ee90...
==========

[commit-bot: I haz the power, 2017-03-25 08:28:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/34dcca73d8f6406f791804d4ee90...