Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2772903002: Removed invalid DCHECK from |loadWithParams:|. (Closed)

Created:
3 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 9 months ago
Reviewers:
Olivier
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed invalid DCHECK from |loadWithParams:|. Omnibox legitimately passes PAGE_TRANSITION_RELOAD for the same page loads. BUG=703709 Review-Url: https://codereview.chromium.org/2772903002 Cr-Commit-Position: refs/heads/master@{#459441} Committed: https://chromium.googlesource.com/chromium/src/+/e6eb96d661fb4e2ddf0ab5baaf6ee389854f0a86

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
3 years, 9 months ago (2017-03-23 21:14:28 UTC) #2
Olivier
lgtm
3 years, 9 months ago (2017-03-24 08:39:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772903002/1
3 years, 9 months ago (2017-03-24 15:43:00 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 16:06:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e6eb96d661fb4e2ddf0ab5baaf6e...

Powered by Google App Engine
This is Rietveld 408576698