Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 2772883002: [Chromecast] Fix assert failure + add test in SwapWithBounds path (Closed)

Created:
3 years, 9 months ago by halliwell
Modified:
3 years, 9 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Fix assert failure + add test in SwapWithBounds path GLRenderer::SwapBuffers cannot access current_frame() - it fails DCHECK(current_frame_valid_). Add a test to actually exercise the SwapWithBounds codepath in GLRenderer. BUG=687690 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2772883002 Cr-Commit-Position: refs/heads/master@{#459618} Committed: https://chromium.googlesource.com/chromium/src/+/ad19ce4f06f1a12bf01780f85cef87e4e16fd8b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -1 line) Patch
M cc/output/gl_renderer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/output/gl_renderer.cc View 2 chunks +4 lines, -1 line 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 chunk +100 lines, -0 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
halliwell
3 years, 9 months ago (2017-03-23 19:06:59 UTC) #4
danakj
LGTM
3 years, 9 months ago (2017-03-24 20:03:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772883002/1
3 years, 9 months ago (2017-03-24 20:12:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/391038)
3 years, 9 months ago (2017-03-24 21:40:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772883002/1
3 years, 9 months ago (2017-03-25 00:18:45 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-25 01:51:19 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ad19ce4f06f1a12bf01780f85cef...

Powered by Google App Engine
This is Rietveld 408576698