Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2772863002: Delete MenuController Nested Message Loop (Closed)

Created:
3 years, 9 months ago by jonross
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete MenuController Nested Message Loop All menu usage has been converted from the older nested message loop style, to using the new asynchronous code path. There have been several milestones since, and the bugs found addressed. This change removes the old code path. BUG=557130

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : remove another async flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -648 lines) Patch
M ui/views/BUILD.gn View 1 2 chunks +0 lines, -5 lines 0 comments Download
M ui/views/controls/menu/menu_controller.h View 1 2 7 chunks +4 lines, -26 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 16 chunks +54 lines, -100 lines 0 comments Download
M ui/views/controls/menu/menu_controller_unittest.cc View 1 2 34 chunks +27 lines, -222 lines 0 comments Download
D ui/views/controls/menu/menu_message_loop.h View 1 1 chunk +0 lines, -46 lines 0 comments Download
D ui/views/controls/menu/menu_message_loop_aura.h View 1 1 chunk +0 lines, -34 lines 0 comments Download
D ui/views/controls/menu/menu_message_loop_aura.cc View 1 1 chunk +0 lines, -87 lines 0 comments Download
D ui/views/controls/menu/menu_message_loop_mac.h View 1 1 chunk +0 lines, -35 lines 0 comments Download
D ui/views/controls/menu/menu_message_loop_mac.cc View 1 1 chunk +0 lines, -44 lines 0 comments Download
M ui/views/controls/menu/menu_runner_impl.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/controls/menu/menu_runner_impl.cc View 1 6 chunks +25 lines, -46 lines 0 comments Download

Messages

Total messages: 12 (12 generated)
jonross
The CQ bit was checked by jonross@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-23 17:46:35 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772863002/1
3 years, 9 months ago (2017-03-23 17:47:13 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-23 18:18:51 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/192989)
3 years, 9 months ago (2017-03-23 18:18:52 UTC) #4
jonross
The CQ bit was checked by jonross@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-23 21:12:48 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772863002/20001
3 years, 9 months ago (2017-03-23 21:13:28 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-23 21:46:28 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/413669)
3 years, 9 months ago (2017-03-23 21:46:29 UTC) #8
jonross
The CQ bit was checked by jonross@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-24 00:35:57 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772863002/40001
3 years, 9 months ago (2017-03-24 00:36:29 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-24 02:21:33 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 02:21:34 UTC) #12 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698