Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2772853003: [debug] extend debug-evaluate by Map builtins. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] extend debug-evaluate by Map builtins. R=jgruber@chromium.org BUG=v8:5821 Review-Url: https://codereview.chromium.org/2772853003 Cr-Commit-Position: refs/heads/master@{#44092} Committed: https://chromium.googlesource.com/v8/v8/+/f764a5c8c0c973a1996b2f86e009b592771bd8c4

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -57 lines) Patch
M src/debug/debug-evaluate.cc View 3 chunks +66 lines, -57 lines 1 comment Download
M test/debugger/debug/debug-evaluate-no-side-effect-builtins-2.js View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Yang
3 years, 9 months ago (2017-03-23 17:30:09 UTC) #1
jgruber
lgtm https://codereview.chromium.org/2772853003/diff/1/src/debug/debug-evaluate.cc File src/debug/debug-evaluate.cc (right): https://codereview.chromium.org/2772853003/diff/1/src/debug/debug-evaluate.cc#newcode263 src/debug/debug-evaluate.cc:263: #define INTRINSIC_WHITELIST(V) \ Nice.
3 years, 9 months ago (2017-03-24 08:24:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772853003/1
3 years, 9 months ago (2017-03-24 10:14:01 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 10:55:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f764a5c8c0c973a1996b2f86e009b592771...

Powered by Google App Engine
This is Rietveld 408576698