Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2772853002: Fix an issue that OMA download is not intercepted on Android (Closed)

Created:
3 years, 9 months ago by qinmin
Modified:
3 years, 9 months ago
CC:
chromium-reviews, asanka, loading-reviews_chromium.org, Randy Smith (Not in Mondays), mmenke, agrieve+watch_chromium.org
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix an issue that OMA download is not intercepted on Android We use InterceptDownloadResourceThrottle to intercept OMA download. However, MimeSniffingResourceHandler::MaybeStartInterception always start the download with is_new_request == false. This CL fixes the issue by moving InterceptDownloadResourceThrottle out the if(is_new_request) block. And append the throttle after AppendStandardResourceThrottles so we won't skip safe browsing This CL also fixes an issue that displayed filename is null on the snackbar TBR=mmenke@chromium.org,dtrainor@chromium.org BUG=675559 Review-Url: https://codereview.chromium.org/2757403002 Cr-Commit-Position: refs/heads/master@{#458666} (cherry picked from commit 24c83fb4132db2d3ec271c7ae3ad22f6dcc9b5bc)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 4 chunks +26 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java View 4 chunks +55 lines, -0 lines 0 comments Download
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
qinmin
3 years, 9 months ago (2017-03-23 17:05:31 UTC) #1 
Description was changed from

==========
Fix an issue that OMA download is not intercepted on Android

We use InterceptDownloadResourceThrottle to intercept OMA download.
However, MimeSniffingResourceHandler::MaybeStartInterception always start
the download with is_new_request == false.
This CL fixes the issue by moving InterceptDownloadResourceThrottle out the
if(is_new_request) block.
And append the throttle after AppendStandardResourceThrottles so we won't skip
safe browsing
This CL also fixes an issue that displayed filename is null on the snackbar

TBR=mmenke@chromium.org,dtrainor@chromium.org
BUG=675559

Review-Url: https://codereview.chromium.org/2757403002
Cr-Commit-Position: refs/heads/master@{#458666}
(cherry picked from commit 24c83fb4132db2d3ec271c7ae3ad22f6dcc9b5bc)
==========

to

==========
Fix an issue that OMA download is not intercepted on Android

We use InterceptDownloadResourceThrottle to intercept OMA download.
However, MimeSniffingResourceHandler::MaybeStartInterception always start
the download with is_new_request == false.
This CL fixes the issue by moving InterceptDownloadResourceThrottle out the
if(is_new_request) block.
And append the throttle after AppendStandardResourceThrottles so we won't skip
safe browsing
This CL also fixes an issue that displayed filename is null on the snackbar

TBR=mmenke@chromium.org,dtrainor@chromium.org
BUG=675559

Review-Url: https://codereview.chromium.org/2757403002
Cr-Commit-Position: refs/heads/master@{#458666}
(cherry picked from commit 24c83fb4132db2d3ec271c7ae3ad22f6dcc9b5bc)
==========

Powered by Google App Engine
This is Rietveld 408576698