Fix an issue that OMA download is not intercepted on Android

Fix an issue that OMA download is not intercepted on Android

We use InterceptDownloadResourceThrottle to intercept OMA download.
However, MimeSniffingResourceHandler::MaybeStartInterception always start
the download with is_new_request == false.
This CL fixes the issue by moving InterceptDownloadResourceThrottle out the if(is_new_request) block.
And append the throttle after AppendStandardResourceThrottles so we won't skip safe browsing
This CL also fixes an issue that displayed filename is null on the snackbar


BUG=675559
Review-Url: https://codereview.chromium.org/2757403002
Cr-Commit-Position: refs/heads/master@{#458666}
Committed: https://chromium.googlesource.com/chromium/src/+/24c83fb4132db2d3ec271c7ae3ad22f6dcc9b5bc

[qinmin, 2017-03-20 20:27:21]

qinmin@chromium.org changed reviewers:
+ dtrainor@chromium.org, mmenke@chromium.org

[qinmin, 2017-03-20 20:27:22]

PTAL
+mmenke@ for chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc

+dtrainor@ for java changes

[mmenke, 2017-03-20 20:36:23]

On 2017/03/20 20:27:22, qinmin wrote:
> PTAL
> +mmenke@ for chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
> 
> +dtrainor@ for java changes

Any way to create a test for this?

[David Trainor- moved to gerrit, 2017-03-21 15:38:00]

lgtm % mmenke comments

[qinmin, 2017-03-21 16:44:20]

On 2017/03/20 20:36:23, mmenke wrote:
> On 2017/03/20 20:27:22, qinmin wrote:
> > PTAL
> > +mmenke@ for
chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
> > 
> > +dtrainor@ for java changes
> 
> Any way to create a test for this?


Android doesn't build browser_tests, so added a java instrumentation test for
this.

[mmenke, 2017-03-21 21:41:19]

On 2017/03/21 16:44:20, qinmin wrote:
> On 2017/03/20 20:36:23, mmenke wrote:
> > On 2017/03/20 20:27:22, qinmin wrote:
> > > PTAL
> > > +mmenke@ for
> chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
> > > 
> > > +dtrainor@ for java changes
> > 
> > Any way to create a test for this?
> 
> 
> Android doesn't build browser_tests, so added a java instrumentation test for
> this.

Thanks!  LGTM, though you may want to have someone more familiar with what's
going on review the test.

Sorry for the late reply, didn't somehow missed the email.

[qinmin, 2017-03-21 22:47:10]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2017-03-21 22:47:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2757403002/#ps20001
(title: "add test")

[commit-bot: I haz the power, 2017-03-21 22:47:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 22:59:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 22:59:41]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[qinmin, 2017-03-22 06:30:18]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2017-03-22 06:30:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2757403002/#ps40001
(title: "fix clang warnings")

[commit-bot: I haz the power, 2017-03-22 06:31:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 07:28:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490164218224400,
"parent_rev": "335600d2502aff53ea0d7ef90cf6563b5634fccd", "commit_rev":
"24c83fb4132db2d3ec271c7ae3ad22f6dcc9b5bc"}

[commit-bot: I haz the power, 2017-03-22 07:28:52]

Description was changed from

==========
Fix an issue that OMA download is not intercepted on Android

We use InterceptDownloadResourceThrottle to intercept OMA download.
However, MimeSniffingResourceHandler::MaybeStartInterception always start
the download with is_new_request == false.
This CL fixes the issue by moving InterceptDownloadResourceThrottle out the
if(is_new_request) block.
And append the throttle after AppendStandardResourceThrottles so we won't skip
safe browsing
This CL also fixes an issue that displayed filename is null on the snackbar


BUG=675559
==========

to

==========
Fix an issue that OMA download is not intercepted on Android

We use InterceptDownloadResourceThrottle to intercept OMA download.
However, MimeSniffingResourceHandler::MaybeStartInterception always start
the download with is_new_request == false.
This CL fixes the issue by moving InterceptDownloadResourceThrottle out the
if(is_new_request) block.
And append the throttle after AppendStandardResourceThrottles so we won't skip
safe browsing
This CL also fixes an issue that displayed filename is null on the snackbar


BUG=675559

Review-Url: https://codereview.chromium.org/2757403002
Cr-Commit-Position: refs/heads/master@{#458666}
Committed:
https://chromium.googlesource.com/chromium/src/+/24c83fb4132db2d3ec271c7ae3ad...
==========

[commit-bot: I haz the power, 2017-03-22 07:28:53]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/24c83fb4132db2d3ec271c7ae3ad...