Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2772793003: android: ChildProcessLauncherAndroid follow up cleanups (Closed)

Created:
3 years, 9 months ago by boliu
Modified:
3 years, 9 months ago
Reviewers:
Jay Civelli
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

android: ChildProcessLauncherAndroid follow up cleanups This is a folow up for to https://chromium.googlesource.com/chromium/src/+/4ac59a56d54826dbdfc5b17b2e8875863065b0b8 Move jni namespace to content::internal to match native code. Inline some Java_ChildProcessLauncer_* calls that has only a single caller. BUG=689758 Review-Url: https://codereview.chromium.org/2772793003 Cr-Commit-Position: refs/heads/master@{#459307} Committed: https://chromium.googlesource.com/chromium/src/+/d604de96c960021b33f929e9cdf9eca8079ad92b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -72 lines) Patch
M content/browser/child_process_launcher_helper_android.cc View 7 chunks +50 lines, -71 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
boliu
ptal
3 years, 9 months ago (2017-03-23 23:54:32 UTC) #2
Jay Civelli
lgtm
3 years, 9 months ago (2017-03-24 00:22:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772793003/1
3 years, 9 months ago (2017-03-24 00:36:31 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 00:50:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d604de96c960021b33f929e9cdf9...

Powered by Google App Engine
This is Rietveld 408576698