[Sync] Don't display passphrase notification if user dismissed previous one

[Sync] Don't display passphrase notification if user dismissed previous one

The scenario:
- User gets notification to enter passphrase on ChromeOS, then dismisses it
- When user opens sync settings this notification is displayed again even though
  user intention is likely to enter passphrase.

The solution is not to display passphrase notification if user has dismissed
previous one. Notification will be displayed after user signs in into profile
and for any new passphrase (user entered previous one and then changed it again
from remote device).

BUG=620133
R=skym@chromium.org

Review-Url: https://codereview.chromium.org/2772783004
Cr-Commit-Position: refs/heads/master@{#459937}
Committed: https://chromium.googlesource.com/chromium/src/+/2870786bb6d391f0ee19f87a84f4278c95154fb0

[pavely, 2017-03-24 23:14:11]

The CQ bit was checked by pavely@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 23:14:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 23:52:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 23:52:02]

Dry run: This issue passed the CQ dry run.

[skym, 2017-03-27 20:56:56]

lgtm

https://codereview.chromium.org/2772783004/diff/1/chrome/browser/sync/sync_er...
File chrome/browser/sync/sync_error_notifier_ash_unittest.cc (right):

https://codereview.chromium.org/2772783004/diff/1/chrome/browser/sync/sync_er...
chrome/browser/sync/sync_error_notifier_ash_unittest.cc:154:
ASSERT_FALSE(notification->message().empty());
Nice catch

https://codereview.chromium.org/2772783004/diff/1/chrome/browser/sync/sync_er...
chrome/browser/sync/sync_error_notifier_ash_unittest.cc:205: true /* signed in
*/, true /* error */,
Did you git cl format this?

[pavely, 2017-03-27 21:06:50]

The CQ bit was checked by pavely@chromium.org

[pavely, 2017-03-27 21:06:54]

https://codereview.chromium.org/2772783004/diff/1/chrome/browser/sync/sync_er...
File chrome/browser/sync/sync_error_notifier_ash_unittest.cc (right):

https://codereview.chromium.org/2772783004/diff/1/chrome/browser/sync/sync_er...
chrome/browser/sync/sync_error_notifier_ash_unittest.cc:205: true /* signed in
*/, true /* error */,
On 2017/03/27 20:56:56, skym wrote:
> Did you git cl format this?

Yeah, I did. The result is worse than before, but if I reverted it git cl format
would do the same thing the next time file is changed.

[commit-bot: I haz the power, 2017-03-27 21:07:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 22:57:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 22:57:40]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[pavely, 2017-03-27 23:01:26]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2017-03-27 23:02:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 23:40:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490655686701020, "parent_rev":
"24461157ecb4dfbb9b8a600845be32514854df51", "commit_rev":
"2870786bb6d391f0ee19f87a84f4278c95154fb0"}

[commit-bot: I haz the power, 2017-03-27 23:41:40]

Description was changed from

==========
[Sync] Don't display passphrase notification if user dismissed previous one

The scenario:
- User gets notification to enter passphrase on ChromeOS, then dismisses it
- When user opens sync settings this notification is displayed again even though
  user intention is likely to enter passphrase.

The solution is not to display passphrase notification if user has dismissed
previous one. Notification will be displayed after user signs in into profile
and for any new passphrase (user entered previous one and then changed it again
from remote device).

BUG=620133
R=skym@chromium.org
==========

to

==========
[Sync] Don't display passphrase notification if user dismissed previous one

The scenario:
- User gets notification to enter passphrase on ChromeOS, then dismisses it
- When user opens sync settings this notification is displayed again even though
  user intention is likely to enter passphrase.

The solution is not to display passphrase notification if user has dismissed
previous one. Notification will be displayed after user signs in into profile
and for any new passphrase (user entered previous one and then changed it again
from remote device).

BUG=620133
R=skym@chromium.org

Review-Url: https://codereview.chromium.org/2772783004
Cr-Commit-Position: refs/heads/master@{#459937}
Committed:
https://chromium.googlesource.com/chromium/src/+/2870786bb6d391f0ee19f87a84f4...
==========

[commit-bot: I haz the power, 2017-03-27 23:41:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2870786bb6d391f0ee19f87a84f4...