Changed sample to script-sample in security policy violation events

Changed sample to script-sample in security policy violation events

Spec: https://w3c.github.io/webappsec-csp/#deprecated-serialize-violation

BUG=606774
Review-Url: https://codereview.chromium.org/2772783002
Cr-Commit-Position: refs/heads/master@{#459079}
Committed: https://chromium.googlesource.com/chromium/src/+/d6603f841ad186aa86c7df158b549c88da23c27b

[andypaicu, 2017-03-23 10:04:44]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 10:04:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[andypaicu, 2017-03-23 10:05:26]

andypaicu@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2017-03-23 10:17:54]

Probably worth pointing to the note in
https://w3c.github.io/webappsec-csp/#deprecated-serialize-violation to explain
the insanity. :)

https://codereview.chromium.org/2772783002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/SecurityPolicyViolationEvent.h
(right):

https://codereview.chromium.org/2772783002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/SecurityPolicyViolationEvent.h:53: const
String& scriptSample() const { return m_scriptSample; }
This should stay `sample`, as we just discussed. ;)

https://codereview.chromium.org/2772783002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp (right):

https://codereview.chromium.org/2772783002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp:1214:
cspReport->setString("script-sample", violationData.scriptSample());
This is basically the only line that should change.

[andypaicu, 2017-03-23 10:27:15]

The CQ bit was unchecked by andypaicu@chromium.org

[andypaicu, 2017-03-23 10:30:52]

https://codereview.chromium.org/2772783002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/SecurityPolicyViolationEvent.h
(right):

https://codereview.chromium.org/2772783002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/SecurityPolicyViolationEvent.h:53: const
String& scriptSample() const { return m_scriptSample; }
On 2017/03/23 at 10:17:54, Mike West wrote:
> This should stay `sample`, as we just discussed. ;)

Done

https://codereview.chromium.org/2772783002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp (right):

https://codereview.chromium.org/2772783002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp:1214:
cspReport->setString("script-sample", violationData.scriptSample());
On 2017/03/23 at 10:17:54, Mike West wrote:
> This is basically the only line that should change.

Done

[Mike West, 2017-03-23 11:09:37]

LGTM. Please link to the spec in the CL description. :)

https://codereview.chromium.org/2772783002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/SecurityPolicyViolationEventInit.idl
(right):

https://codereview.chromium.org/2772783002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/SecurityPolicyViolationEventInit.idl:21: 
Unrelated whitespace change?

[andypaicu, 2017-03-23 11:12:40]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 11:12:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[andypaicu, 2017-03-23 11:27:10]

Description was changed from

==========
Changed sample to script-sample in security policy violation events

BUG=606774
==========

to

==========
Changed sample to script-sample in security policy violation events

Spec: https://w3c.github.io/webappsec-csp/#deprecated-serialize-violation

BUG=606774
==========

[andypaicu, 2017-03-23 11:27:36]

The CQ bit was unchecked by andypaicu@chromium.org

[andypaicu, 2017-03-23 11:39:03]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 11:39:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[andypaicu, 2017-03-23 11:39:52]

On 2017/03/23 at 11:09:37, mkwst wrote:
> LGTM. Please link to the spec in the CL description. :)
> 
>
https://codereview.chromium.org/2772783002/diff/20001/third_party/WebKit/Sour...
> File
third_party/WebKit/Source/core/events/SecurityPolicyViolationEventInit.idl
(right):
> 
>
https://codereview.chromium.org/2772783002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/events/SecurityPolicyViolationEventInit.idl:21:

> Unrelated whitespace change?

Linked.

It bothered me that there was a newline in the other idl file but not in this
one :). I've removed it from both.

[commit-bot: I haz the power, 2017-03-23 13:05:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 13:05:05]

Dry run: This issue passed the CQ dry run.

[andypaicu, 2017-03-23 14:31:23]

The CQ bit was checked by andypaicu@chromium.org

[andypaicu, 2017-03-23 14:31:23]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2772783002/#ps40001
(title: "Whitespace cleanup")

[commit-bot: I haz the power, 2017-03-23 14:31:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 14:38:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490279483331710,
"parent_rev": "e187cbe0c5af79ca2cd9b6ade3d36a14060678eb", "commit_rev":
"d6603f841ad186aa86c7df158b549c88da23c27b"}

[commit-bot: I haz the power, 2017-03-23 14:39:40]

Description was changed from

==========
Changed sample to script-sample in security policy violation events

Spec: https://w3c.github.io/webappsec-csp/#deprecated-serialize-violation

BUG=606774
==========

to

==========
Changed sample to script-sample in security policy violation events

Spec: https://w3c.github.io/webappsec-csp/#deprecated-serialize-violation

BUG=606774

Review-Url: https://codereview.chromium.org/2772783002
Cr-Commit-Position: refs/heads/master@{#459079}
Committed:
https://chromium.googlesource.com/chromium/src/+/d6603f841ad186aa86c7df158b54...
==========

[commit-bot: I haz the power, 2017-03-23 14:39:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d6603f841ad186aa86c7df158b54...