UI change for adjustable large cursor

UI change for adjustable large cursor

- Change the label of the slider.
- Add small and large labels to the slider.
- Align the slider to the right side in LTR (left side in RTL).
- Fix an issue where the slider was not disabled even if large cursor is
  disabled.

BUG=591493
TEST=Open the accessibility section of MD settings page, and confirm
     that those changes are made.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2772743002
Cr-Commit-Position: refs/heads/master@{#459952}
Committed: https://chromium.googlesource.com/chromium/src/+/2c8645c1be63b83102853e2f74ce8e62c17542e2

[yawano, 2017-03-23 07:37:30]

Description was changed from

==========
UI change for adjustable large cursor

- Add small and large labels to the slider.
- Align the slider to the right side in LTR (left side in RTL).
- Fix an issue where the slider was not disabled even if large cursor is
  disabled.

BUG=591493
TEST=Open the accessibility section of MD settings page, and confirm
     that those changes are made.
==========

to

==========
UI change for adjustable large cursor

- Add small and large labels to the slider.
- Align the slider to the right side in LTR (left side in RTL).
- Fix an issue where the slider was not disabled even if large cursor is
  disabled.

BUG=591493
TEST=Open the accessibility section of MD settings page, and confirm
     that those changes are made.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yawano, 2017-03-23 07:39:47]

yawano@chromium.org changed reviewers:
+ dbeam@chromium.org

[yawano, 2017-03-23 07:39:47]

PTAL. Thank you!

[yawano, 2017-03-24 01:20:30]

Description was changed from

==========
UI change for adjustable large cursor

- Add small and large labels to the slider.
- Align the slider to the right side in LTR (left side in RTL).
- Fix an issue where the slider was not disabled even if large cursor is
  disabled.

BUG=591493
TEST=Open the accessibility section of MD settings page, and confirm
     that those changes are made.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
UI change for adjustable large cursor

- Change the label of the slider.
- Add small and large labels to the slider.
- Align the slider to the right side in LTR (left side in RTL).
- Fix an issue where the slider was not disabled even if large cursor is
  disabled.

BUG=591493
TEST=Open the accessibility section of MD settings page, and confirm
     that those changes are made.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yawano, 2017-03-24 01:21:14]

Uploaded a new patch set to change the label.

[Dan Beam, 2017-03-25 06:55:49]

lgtm

https://codereview.chromium.org/2772743002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/a11y_page/manage_a11y_page.html (right):

https://codereview.chromium.org/2772743002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/a11y_page/manage_a11y_page.html:22:
-webkit-margin-start: 56px;
what's this doing?  can this be made up of other variables?  it just looks like
it's a few spacing variables combined

[yawano, 2017-03-27 10:52:15]

Fixed to use a variable. PTAL. Thank you!

https://codereview.chromium.org/2772743002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/a11y_page/manage_a11y_page.html (right):

https://codereview.chromium.org/2772743002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/a11y_page/manage_a11y_page.html:22:
-webkit-margin-start: 56px;
We had the exact variable for indent. Thank you!

[Dan Beam, 2017-03-27 11:13:17]

still lgtm

[yawano, 2017-03-27 23:21:29]

On 2017/03/27 11:13:17, Dan Beam (slow) wrote:
> still lgtm

Thank you!

[yawano, 2017-03-27 23:21:36]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2017-03-27 23:22:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 00:39:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490656896282970,
"parent_rev": "d5f25f6e1a4b59c43fb7a1fdfb68e2e49df8f62b", "commit_rev":
"2c8645c1be63b83102853e2f74ce8e62c17542e2"}

[commit-bot: I haz the power, 2017-03-28 00:40:46]

Description was changed from

==========
UI change for adjustable large cursor

- Change the label of the slider.
- Add small and large labels to the slider.
- Align the slider to the right side in LTR (left side in RTL).
- Fix an issue where the slider was not disabled even if large cursor is
  disabled.

BUG=591493
TEST=Open the accessibility section of MD settings page, and confirm
     that those changes are made.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
UI change for adjustable large cursor

- Change the label of the slider.
- Add small and large labels to the slider.
- Align the slider to the right side in LTR (left side in RTL).
- Fix an issue where the slider was not disabled even if large cursor is
  disabled.

BUG=591493
TEST=Open the accessibility section of MD settings page, and confirm
     that those changes are made.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2772743002
Cr-Commit-Position: refs/heads/master@{#459952}
Committed:
https://chromium.googlesource.com/chromium/src/+/2c8645c1be63b83102853e2f74ce...
==========

[commit-bot: I haz the power, 2017-03-28 00:40:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2c8645c1be63b83102853e2f74ce...