Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Issue 2772723005: Export the current data format version used by ValueSerializer. (Closed)

Created:
3 years, 9 months ago by jbroman
Modified:
3 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Export the current data format version used by ValueSerializer. This enables clients like IndexedDB to know when the data format version has decreased (i.e. the user has switched to an earlier version) and deal with the resulting incompatibility up front. BUG=chromium:704293 Review-Url: https://codereview.chromium.org/2772723005 Cr-Commit-Position: refs/heads/master@{#44391} Committed: https://chromium.googlesource.com/v8/v8/+/e46f841849ef541e31c2cc4891c1ce44e57285b1

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M include/v8.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/value-serializer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/value-serializer.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
jbroman
IndexedDB previously used this version to allow database opening to fail fast. Now that this ...
3 years, 8 months ago (2017-03-30 18:44:00 UTC) #9
Jakob Kummerow
lgtm
3 years, 8 months ago (2017-03-31 21:27:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772723005/20001
3 years, 8 months ago (2017-04-04 18:50:59 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 19:26:39 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e46f841849ef541e31c2cc4891c1ce44e57...

Powered by Google App Engine
This is Rietveld 408576698