Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2772723002: Add detailed use counters for document.registerElement use. (Closed)

Created:
3 years, 9 months ago by dominicc (has gone to gerrit)
Modified:
3 years, 9 months ago
Reviewers:
blink-bindings-reviews, haraken, hayato, foolip
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add detailed use counters for document.registerElement use. BUG=660759 Review-Url: https://codereview.chromium.org/2772723002 Cr-Commit-Position: refs/heads/master@{#459995} Committed: https://chromium.googlesource.com/chromium/src/+/85a9028894cd935c243b4e6927b91c9759964222

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Bring patch to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.cpp View 2 chunks +13 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (15 generated)
dominicc (has gone to gerrit)
PTAL
3 years, 9 months ago (2017-03-23 06:39:18 UTC) #4
foolip
lgtm
3 years, 9 months ago (2017-03-23 06:47:20 UTC) #5
foolip
hayato@, I'm not very familiar with custom elements and while both dominicc@ and I think ...
3 years, 9 months ago (2017-03-23 06:51:04 UTC) #7
hayato
lgtm
3 years, 9 months ago (2017-03-23 07:41:17 UTC) #10
haraken
bindings/ and histograms LGTM
3 years, 9 months ago (2017-03-23 08:07:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772723002/20001
3 years, 9 months ago (2017-03-24 04:53:25 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/179167)
3 years, 9 months ago (2017-03-24 05:56:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772723002/20001
3 years, 9 months ago (2017-03-24 08:56:19 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/393815) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-24 09:03:47 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772723002/40001
3 years, 9 months ago (2017-03-28 00:48:53 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 03:26:36 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/85a9028894cd935c243b4e6927b9...

Powered by Google App Engine
This is Rietveld 408576698