Chromium Code Reviews| Index: chrome/browser/ui/toolbar/app_menu_model.cc |
| diff --git a/chrome/browser/ui/toolbar/app_menu_model.cc b/chrome/browser/ui/toolbar/app_menu_model.cc |
| index 7ef2d8ba5794dbd1cc42f69383d7da3e3ba8e293..6092a5e4ccb2e3e2189cd12f278d1e38efd2627d 100644 |
| --- a/chrome/browser/ui/toolbar/app_menu_model.cc |
| +++ b/chrome/browser/ui/toolbar/app_menu_model.cc |
| @@ -176,10 +176,6 @@ ToolsMenuModel::~ToolsMenuModel() {} |
| // - Developer tools. |
| // - Option to enable profiling. |
| void ToolsMenuModel::Build(Browser* browser) { |
| - bool show_create_shortcuts = true; |
| -#if defined(OS_CHROMEOS) || defined(OS_MACOSX) || defined(USE_ASH) |
| - show_create_shortcuts = false; |
| -#endif |
| if (base::CommandLine::ForCurrentProcess()->HasSwitch( |
| switches::kEnableSaveAsMenuLabelExperiment) || |
| base::FieldTrialList::FindFullName("SaveAsMenuText") == "download") { |
| @@ -197,8 +193,6 @@ void ToolsMenuModel::Build(Browser* browser) { |
| string_id = IDS_ADD_TO_SHELF; |
| #endif // defined(USE_ASH) |
| AddItemWithStringId(IDC_CREATE_HOSTED_APP, string_id); |
| - } else if (show_create_shortcuts) { |
| - AddItemWithStringId(IDC_CREATE_SHORTCUTS, IDS_CREATE_SHORTCUTS); |
|
grt (UTC plus 2)
2017/04/05 08:28:00
please remove IDS_CREATE_SHORTCUTS from chrome/app
tapted
2017/04/05 12:35:44
Done.
|
| } |
| AddSeparator(ui::NORMAL_SEPARATOR); |
| @@ -437,12 +431,6 @@ void AppMenuModel::LogMenuMetrics(int command_id) { |
| } |
| LogMenuAction(MENU_ACTION_CREATE_HOSTED_APP); |
| break; |
| - case IDC_CREATE_SHORTCUTS: |
| - if (!uma_action_recorded_) |
| - UMA_HISTOGRAM_MEDIUM_TIMES("WrenchMenu.TimeToAction.CreateShortcuts", |
|
grt (UTC plus 2)
2017/04/05 08:28:00
mark this suffix as obsolete in histograms.xml
tapted
2017/04/05 12:35:43
I think I got this one already :). (just.. histogr
grt (UTC plus 2)
2017/04/05 13:32:05
Indeed! Apologies for the false alarm.
|
| - delta); |
| - LogMenuAction(MENU_ACTION_CREATE_SHORTCUTS); |
| - break; |
| case IDC_MANAGE_EXTENSIONS: |
| if (!uma_action_recorded_) { |
| UMA_HISTOGRAM_MEDIUM_TIMES("WrenchMenu.TimeToAction.ManageExtensions", |