Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2772613003: views: don't use open-folder icons in TreeView on Mac (Closed)

Created:
3 years, 9 months ago by Elly Fong-Jones
Modified:
3 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

views: don't use open-folder icons in TreeView on Mac Native Cocoa TreeViews do not have this behavior, so disable it in Views TreeViews on Mac also. BUG=605589 Review-Url: https://codereview.chromium.org/2772613003 Cr-Commit-Position: refs/heads/master@{#459222} Committed: https://chromium.googlesource.com/chromium/src/+/7742bafdff7eb65a0528f68a37545da0a89be113

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M ui/views/controls/tree/tree_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/style/platform_style.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/style/platform_style.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/style/platform_style_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Elly Fong-Jones
sky: ptal? :)
3 years, 9 months ago (2017-03-23 17:58:51 UTC) #3
sky
LGTM
3 years, 9 months ago (2017-03-23 18:52:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772613003/1
3 years, 9 months ago (2017-03-23 20:20:52 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 21:19:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7742bafdff7eb65a0528f68a3754...

Powered by Google App Engine
This is Rietveld 408576698